Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 475753002: Add serializer support for out-of-line constant pool. (Closed)

Created:
6 years, 4 months ago by rmcilroy
Modified:
6 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add serializer support for builtins pointed by inner pointer and root objects pointed to by code for the out-of-line constant pool. This is required for test-serialize tests which fail at the DCHECK on L1874 of serialize.cc otherwise. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23242

Patch Set 1 #

Patch Set 2 : Add support for root pointers from code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M src/serialize.cc View 1 4 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmcilroy
Yang, could you please take a look, thanks.
6 years, 4 months ago (2014-08-14 12:04:21 UTC) #1
rmcilroy
On 2014/08/14 12:04:21, rmcilroy wrote: > Yang, could you please take a look, thanks. I ...
6 years, 4 months ago (2014-08-15 13:04:58 UTC) #2
Yang
On 2014/08/15 13:04:58, rmcilroy wrote: > On 2014/08/14 12:04:21, rmcilroy wrote: > > Yang, could ...
6 years, 4 months ago (2014-08-19 08:04:34 UTC) #3
rmcilroy
6 years, 4 months ago (2014-08-20 14:41:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 23242 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698