Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 475743002: Add a command line flag to specify the scope to use for the permission request API. (Closed)

Created:
6 years, 4 months ago by Bernhard Bauer
Modified:
6 years, 4 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, pam+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add a command line flag to specify the scope to use for the permission request API. BUG=304309, 372381 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289656

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/supervised_user/permission_request_creator_apiary.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Bernhard Bauer
Please review! :)
6 years, 4 months ago (2014-08-14 11:08:39 UTC) #1
Marc Treib
lgtm with a nit below https://codereview.chromium.org/475743002/diff/1/chrome/browser/supervised_user/permission_request_creator_apiary.cc File chrome/browser/supervised_user/permission_request_creator_apiary.cc (right): https://codereview.chromium.org/475743002/diff/1/chrome/browser/supervised_user/permission_request_creator_apiary.cc#newcode75 chrome/browser/supervised_user/permission_request_creator_apiary.cc:75: switches::kPermissionRequestApiScope)) { nit: indent ...
6 years, 4 months ago (2014-08-14 11:23:31 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/475743002/diff/1/chrome/browser/supervised_user/permission_request_creator_apiary.cc File chrome/browser/supervised_user/permission_request_creator_apiary.cc (right): https://codereview.chromium.org/475743002/diff/1/chrome/browser/supervised_user/permission_request_creator_apiary.cc#newcode75 chrome/browser/supervised_user/permission_request_creator_apiary.cc:75: switches::kPermissionRequestApiScope)) { On 2014/08/14 11:23:31, Marc Treib wrote: > ...
6 years, 4 months ago (2014-08-14 12:17:06 UTC) #3
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 4 months ago (2014-08-14 12:17:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/475743002/20001
6 years, 4 months ago (2014-08-14 12:21:17 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-14 17:06:32 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 18:52:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289656

Powered by Google App Engine
This is Rietveld 408576698