Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 475733002: Test case modified to check against the item count in ExternalPopupMenu (Closed)

Created:
6 years, 4 months ago by spartha
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Test case modified to check against the item count in ExternalPopupMenu This is a modified due to the regression caused by https://codereview.chromium.org/415343003/. The test case now checks the number of items in the menu list to not include items with "display: none" [1] https://codereview.chromium.org/475723002/ patch that fixes the regression. BUG=398051, 403299 R=tkent Committed: https://crrev.com/9ff8ce3604c8e47986087d9848030a9b2d0e7078 Cr-Commit-Position: refs/heads/master@{#293119}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix Mac Build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/renderer/external_popup_menu_browsertest.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
spartha
The test case has been modified to check for item count. PTAL
6 years, 4 months ago (2014-08-14 11:08:56 UTC) #1
spartha
On 2014/08/14 11:08:56, spartha wrote: > The test case has been modified to check for ...
6 years, 4 months ago (2014-08-26 07:54:42 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-02 10:15:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/475733002/1
6 years, 3 months ago (2014-09-03 05:24:53 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-09-03 05:41:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/11331)
6 years, 3 months ago (2014-09-03 05:44:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/475733002/20001
6 years, 3 months ago (2014-09-03 08:53:30 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-09-03 09:44:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/475733002/40001
6 years, 3 months ago (2014-09-03 10:18:06 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 3be5ef45751d18bef047762fc3d775f436000c3d
6 years, 3 months ago (2014-09-03 11:22:02 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:25:13 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9ff8ce3604c8e47986087d9848030a9b2d0e7078
Cr-Commit-Position: refs/heads/master@{#293119}

Powered by Google App Engine
This is Rietveld 408576698