Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Unified Diff: runtime/vm/debugger.cc

Issue 47573002: Reland https://code.google.com/p/dart/source/detail?r=29315: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc (revision 29317)
+++ runtime/vm/debugger.cc (working copy)
@@ -864,7 +864,6 @@
Debugger::~Debugger() {
- PortMap::ClosePort(isolate_id_);
isolate_id_ = ILLEGAL_ISOLATE_ID;
ASSERT(!in_event_notification_);
ASSERT(src_breakpoints_ == NULL);
@@ -1920,11 +1919,10 @@
return;
}
isolate_ = isolate;
- // Create a port here, we don't expect to receive any messages on this port.
+ // Use the isolate's control port as the isolate_id for debugging.
// This port will be used as a unique ID to represet the isolate in the
// debugger wire protocol messages.
- // NOTE: SetLive is never called on this port.
- isolate_id_ = PortMap::CreatePort(isolate->message_handler());
Ivan Posva 2013/10/27 14:33:17 Since the main port (aka control port) survives to
+ isolate_id_ = isolate->main_port();
initialized_ = true;
// Signal isolate creation event.

Powered by Google App Engine
This is Rietveld 408576698