Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: Source/web/ExternalPopupMenu.h

Issue 475723002: Remove blank items from ExternalPopupMenu (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@validityCheck
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/web/ExternalPopupMenu.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ExternalPopupMenu.h
diff --git a/Source/web/ExternalPopupMenu.h b/Source/web/ExternalPopupMenu.h
index c51aa189a2e64c4866dc542c6cdbc96285aecebc..25ac59b74f4875b86464cbcf38e080e72ced3f7a 100644
--- a/Source/web/ExternalPopupMenu.h
+++ b/Source/web/ExternalPopupMenu.h
@@ -56,6 +56,15 @@ public:
ExternalPopupMenu(LocalFrame&, PopupMenuClient*, WebViewImpl&);
virtual ~ExternalPopupMenu();
+
+ // Fills |info| with the popup menu information contained in the
+ // PopupMenuClient associated with this ExternalPopupMenu.
+ // FIXME: public only for test access. Need to revert once gtest
+ // helpers from chromium are available for blink.
+ static void getPopupMenuInfo(WebPopupMenuInfo&, PopupMenuClient&);
+ static int toPopupMenuItemIndex(int index, PopupMenuClient&);
+ static int toExternalPopupMenuItemIndex(int index, PopupMenuClient&);
+
private:
// PopupMenu methods:
virtual void show(const FloatQuad& controlPosition, const IntSize&, int index) OVERRIDE;
@@ -70,11 +79,6 @@ private:
virtual void didCancel() OVERRIDE;
void dispatchEvent(Timer<ExternalPopupMenu>*);
- // Fills |info| with the popup menu information contained in the
- // PopupMenuClient associated with this ExternalPopupMenu.
- void getPopupMenuInfo(WebPopupMenuInfo* info);
- int toPopupMenuItemIndex(int index);
- int toExternalPopupMenuItemIndex(int index);
PopupMenuClient* m_popupMenuClient;
RefPtr<LocalFrame> m_localFrame;
« no previous file with comments | « no previous file | Source/web/ExternalPopupMenu.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698