Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 475683003: Revert of Re-land r289084 - "Make telemetry*_unittests upload to test-results.appspot.com" (Closed)

Created:
6 years, 4 months ago by Paweł Hajdan Jr.
Modified:
6 years, 4 months ago
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org, hinoka
Project:
tools
Visibility:
Public.

Description

Revert of Re-land r289084 - "Make telemetry*_unittests upload to test-results.appspot.com" (patchset #3 of https://codereview.chromium.org/476503002/) Reason for revert: Reverting telemetry-related changes because of breakages like http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%282%29/builds/30795/steps/telemetry_unittests/logs/stdio . Please watch the waterfall after applying the change. Original issue's description: > Re-land r289084 - "Make telemetry*_unittests upload to test-results.appspot.com" > > This version differs from the prior attempt by > > a) changing the logic so that we only upload the results if we're not running on a trysever. > > b) retrieving the repo revisions from the data that bot_update got, rather than whatever was passed in as part of build_properties. Turns out that the build_properties would've only had 'parent_got_revision' set and not 'got_revision', so we were likely referencing keys that didn't exist. > > As part of (b), this changes adds a "properties" property to the bot_update recipe module so that we can retrieve what bot_update actually did. > > R=agable@chromium.org > BUG=323212, 403564 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=289434 TBR=agable@chromium.org,iannucci@chromium.org,dpranke@chromium.org NOTREECHECKS=true NOTRY=true BUG=323212, 403564 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=289491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -383 lines) Patch
M scripts/slave/recipe_modules/bot_update/api.py View 2 chunks +4 lines, -12 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/__init__.py View 2 chunks +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/api.py View 1 chunk +21 lines, -33 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/buildnumber_zero.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_gtest.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__32_.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg_.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg__32_.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1_.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__3_.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__3_.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__3_.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__3_.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__2_.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__2_.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__2_.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__3_.json View 1 chunk +0 lines, -9 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__2_.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Tests.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/one_failure_keeps_going_dynamic_tests.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/runtest.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
Created Revert of Re-land r289084 - "Make telemetry*_unittests upload to test-results.appspot.com"
6 years, 4 months ago (2014-08-14 08:21:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/475683003/1
6 years, 4 months ago (2014-08-14 08:21:53 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 08:23:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (1) as 289491

Powered by Google App Engine
This is Rietveld 408576698