ui/webui/resources/js/cr/ui/list_item.js - Issue 475633006: Typecheck JS files for chrome://extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/list_item.js

Issue 475633006: Typecheck JS files for chrome://extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@D_asserts_codingconvention

Patch Set: looked twice Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/webui/resources/js/cr/ui/list.js ('K') | « ui/webui/resources/js/cr/ui/list.js ('k') | ui/webui/resources/js/cr/ui/list_selection_controller.js » ('j') | ui/webui/resources/js/cr/ui/list_selection_model.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/js/cr/ui/list_item.js

diff --git a/ui/webui/resources/js/cr/ui/list_item.js b/ui/webui/resources/js/cr/ui/list_item.js

index a670a1f27f424f5fffc8623a2abbcedb3c5c5445..dc777f95eb5f5fc9dac747e838434f30f38a6bd5 100644

--- a/ui/webui/resources/js/cr/ui/list_item.js

+++ b/ui/webui/resources/js/cr/ui/list_item.js

@@ -49,7 +49,6 @@ cr.define('cr.ui', function() {

/**

* Whether the item is selected. Setting this does not update the underlying

* selection model. This is only used for display purpose.

- * @type {boolean}

cr.defineProperty(ListItem, 'selected', cr.PropertyKind.BOOL_ATTR,

function() {

@@ -59,13 +58,12 @@ cr.define('cr.ui', function() {

/**

* Whether the item is the lead in a selection. Setting this does not update

* the underlying selection model. This is only used for display purpose.

- * @type {boolean}

cr.defineProperty(ListItem, 'lead', cr.PropertyKind.BOOL_ATTR);

/**

* This item's index in the containing list.

- * @type {number}

+ * type {number}

cr.defineProperty(ListItem, 'listIndex');