Typecheck JS files for chrome://extensions

ui/webui/resources/js/cr/ui/alert_overlay.js

Index: ui/webui/resources/js/cr/ui/alert_overlay.js
diff --git a/ui/webui/resources/js/cr/ui/alert_overlay.js b/ui/webui/resources/js/cr/ui/alert_overlay.js
index 76ec5014d39d521eb6880cd82d850361a1abb954..4bfd081606ab98f30d419dcf34597fb3d80bd7ce 100644
--- a/ui/webui/resources/js/cr/ui/alert_overlay.js
+++ b/ui/webui/resources/js/cr/ui/alert_overlay.js
@@ -42,17 +42,18 @@ cr.define('alertOverlay', function() {
    * callbacks.
    * @param {string} title The alert title to display to the user.
    * @param {string} message The alert message to display to the user.
-   * @param {string=} okTitle The title of the OK button. If undefined or empty,
-   *     no button is shown.
-   * @param {string=} cancelTitle The title of the cancel button. If undefined
-   *     or empty, no button is shown.
-   * @param {function=} okCallback A function to be called when the user presses
-   *     the ok button. Can be undefined if |okTitle| is falsey.
-   * @param {function=} cancelCallback A function to be called when the user
-   *     presses the cancel button. Can be undefined if |cancelTitle| is falsey.
+   * @param {string=} opt_okTitle The title of the OK button. If undefined or
+   *     empty, no button is shown.
+   * @param {string=} opt_cancelTitle The title of the cancel button. If
+   *     undefined or empty, no button is shown.
+   * @param {function()=} opt_okCallback A function to be called when the user
+   *     presses the ok button. Can be undefined if |opt_okTitle| is falsey.
+   * @param {function()=} opt_cancelCallback A function to be called when the
+   *     user presses the cancel button. Can be undefined if |opt_cancelTitle|
+   *     is falsey.
    */
-  function setValues(
-      title, message, okTitle, cancelTitle, okCallback, cancelCallback) {
+  function setValues(title, message, opt_okTitle, opt_cancelTitle,
+      opt_okCallback, opt_cancelCallback) {

[Dan Beam, 2014/08/21 18:27:48]

nit:

  function setValues(title, message, opt_okTitle, opt_cancelTitle,
                     opt_okCallback, opt_cancelCallback) {

[Vitaly Pavlenko, 2014/08/22 01:43:41]

Done.

     if (typeof title != 'undefined')
       $('alertOverlayTitle').textContent = title;
     $('alertOverlayTitle').hidden = typeof title == 'undefined';
@@ -61,15 +62,15 @@ cr.define('alertOverlay', function() {
       $('alertOverlayMessage').textContent = message;
     $('alertOverlayMessage').hidden = typeof message == 'undefined';
 
-    if (okTitle)
-      okButton.textContent = okTitle;
-    okButton.hidden = !okTitle;
-    okButton.clickCallback = okCallback;
+    if (opt_okTitle)
+      okButton.textContent = opt_okTitle;
+    okButton.hidden = !opt_okTitle;
+    okButton.clickCallback = opt_okCallback;
 
-    if (cancelTitle)
-      cancelButton.textContent = cancelTitle;
-    cancelButton.hidden = !cancelTitle;
-    cancelButton.clickCallback = cancelCallback;
+    if (opt_cancelTitle)
+      cancelButton.textContent = opt_cancelTitle;
+    cancelButton.hidden = !opt_cancelTitle;
+    cancelButton.clickCallback = opt_cancelCallback;
   };
 
   // Export