Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2307)

Unified Diff: chrome/browser/resources/extensions/pack_extension_overlay.js

Issue 475633006: Typecheck JS files for chrome://extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@D_asserts_codingconvention
Patch Set: looked twice Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/pack_extension_overlay.js
diff --git a/chrome/browser/resources/extensions/pack_extension_overlay.js b/chrome/browser/resources/extensions/pack_extension_overlay.js
index 22a316501525994545f0585d458331f709dd9408..d951db1c6873d2f7629d5f13e56361c6468e607a 100644
--- a/chrome/browser/resources/extensions/pack_extension_overlay.js
+++ b/chrome/browser/resources/extensions/pack_extension_overlay.js
@@ -60,9 +60,9 @@ cr.define('extensions', function() {
* @private
*/
showFileDialog_: function(selectType, operation, callback) {
- handleFilePathSelected = function(filePath) {
+ window.handleFilePathSelected = function(filePath) {
callback(filePath);
- handleFilePathSelected = function() {};
+ window.handleFilePathSelected = function() {};
};
chrome.send('packExtensionSelectFilePath', [selectType, operation]);
@@ -104,14 +104,14 @@ cr.define('extensions', function() {
'',
function() {
extensions.ExtensionSettings.showOverlay(null);
- },
- null);
+ });
extensions.ExtensionSettings.showOverlay($('alertOverlay'));
};
/**
* Post an alert overlay showing |message|, and upon acknowledgement, close
* the alert overlay and return to showing the PackExtensionOverlay.
+ * @param {string} message
Dan Beam 2014/08/21 18:27:48 nit: The error message.
Vitaly Pavlenko 2014/08/22 01:43:40 Done.
*/
PackExtensionOverlay.showError = function(message) {
alertOverlay.setValues(
@@ -121,8 +121,7 @@ cr.define('extensions', function() {
'',
function() {
extensions.ExtensionSettings.showOverlay($('pack-extension-overlay'));
- },
- null);
+ });
extensions.ExtensionSettings.showOverlay($('alertOverlay'));
};

Powered by Google App Engine
This is Rietveld 408576698