Chromium Code Reviews| Index: chrome/browser/resources/extensions/pack_extension_overlay.js |
| diff --git a/chrome/browser/resources/extensions/pack_extension_overlay.js b/chrome/browser/resources/extensions/pack_extension_overlay.js |
| index 22a316501525994545f0585d458331f709dd9408..d951db1c6873d2f7629d5f13e56361c6468e607a 100644 |
| --- a/chrome/browser/resources/extensions/pack_extension_overlay.js |
| +++ b/chrome/browser/resources/extensions/pack_extension_overlay.js |
| @@ -60,9 +60,9 @@ cr.define('extensions', function() { |
| * @private |
| */ |
| showFileDialog_: function(selectType, operation, callback) { |
| - handleFilePathSelected = function(filePath) { |
| + window.handleFilePathSelected = function(filePath) { |
| callback(filePath); |
| - handleFilePathSelected = function() {}; |
| + window.handleFilePathSelected = function() {}; |
| }; |
| chrome.send('packExtensionSelectFilePath', [selectType, operation]); |
| @@ -104,14 +104,14 @@ cr.define('extensions', function() { |
| '', |
| function() { |
| extensions.ExtensionSettings.showOverlay(null); |
| - }, |
| - null); |
| + }); |
| extensions.ExtensionSettings.showOverlay($('alertOverlay')); |
| }; |
| /** |
| * Post an alert overlay showing |message|, and upon acknowledgement, close |
| * the alert overlay and return to showing the PackExtensionOverlay. |
| + * @param {string} message |
|
Dan Beam
2014/08/21 18:27:48
nit: The error message.
Vitaly Pavlenko
2014/08/22 01:43:40
Done.
|
| */ |
| PackExtensionOverlay.showError = function(message) { |
| alertOverlay.setValues( |
| @@ -121,8 +121,7 @@ cr.define('extensions', function() { |
| '', |
| function() { |
| extensions.ExtensionSettings.showOverlay($('pack-extension-overlay')); |
| - }, |
| - null); |
| + }); |
| extensions.ExtensionSettings.showOverlay($('alertOverlay')); |
| }; |