chrome/browser/resources/extensions/extension_commands_overlay.js - Issue 475633006: Typecheck JS files for chrome://extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_commands_overlay.js

Issue 475633006: Typecheck JS files for chrome://extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@D_asserts_codingconvention

Patch Set: looked twice Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/extensions/extension_command_list.js ('K') | « chrome/browser/resources/extensions/extension_command_list.js ('k') | chrome/browser/resources/extensions/extension_error.js » ('j') | chrome/browser/resources/extensions/extension_error_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extension_commands_overlay.js

diff --git a/chrome/browser/resources/extensions/extension_commands_overlay.js b/chrome/browser/resources/extensions/extension_commands_overlay.js

index 64f595656508977690ddcec4a9466d32bbdd0275..5c77b7c8f0272049d73ce787f4fbd68c334be97a 100644

--- a/chrome/browser/resources/extensions/extension_commands_overlay.js

+++ b/chrome/browser/resources/extensions/extension_commands_overlay.js

@@ -51,6 +51,8 @@ cr.define('extensions', function() {

/**

* Called by the dom_ui_ to re-populate the page with data representing

* the current state of extension commands.

+ * @param {{commands: Array.<{name: string, id: string, commands: ?Array}>}}

Dan Beam 2014/08/21 18:27:47 nit: {!{

Vitaly Pavlenko 2014/08/22 01:43:40 Done.

+ * extensionsData

ExtensionCommandsOverlay.returnExtensionsData = function(extensionsData) {

ExtensionCommandList.prototype.data_ = extensionsData;

@@ -68,7 +70,7 @@ cr.define('extensions', function() {

list.classList.add('empty-extension-commands-list');

else

list.classList.remove('empty-extension-commands-list');

- }

+ };

// Export

return {