Typecheck JS files for chrome://extensions

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
+/**
+ * The type of the extension data object. The definition is based on
+ * chrome/browser/ui/webui/extensions/extension_basic_info.cc
+ * and
+ * chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+ *     ExtensionSettingsHandler::CreateExtensionDetailValue()
+ * @typedef {{allow_reload: boolean,
+ *            allowAllUrls: boolean,
+ *            allowFileAccess: boolean,
+ *            blacklistText: string,
+ *            corruptInstall: boolean,
+ *            dependentExtensions: Array,
+ *            description: string,
+ *            detailsUrl: string,
+ *            enable_show_button: boolean,
+ *            enabled: boolean,
+ *            enabledIncognito: boolean,
+ *            errorCollectionEnabled: (boolean|undefined),
+ *            hasPopupAction: boolean,
+ *            homepageProvided: boolean,
+ *            homepageUrl: string,
+ *            icon: string,
+ *            id: string,
+ *            incognitoCanBeEnabled: boolean,
+ *            installWarnings: (Array|undefined),
+ *            is_hosted_app: boolean,
+ *            is_platform_app: boolean,
+ *            isUnpacked: boolean,
+ *            kioskEnabled: boolean,
+ *            kioskOnly: boolean,
+ *            locationText: string,
+ *            managedInstall: boolean,
+ *            manifestErrors: (Array.<BackendExtensionErrorObject>|undefined),
+ *            name: string,
+ *            offlineEnabled: boolean,
+ *            optionsUrl: string,
+ *            order: number,
+ *            packagedApp: boolean,
+ *            path: (string|undefined),
+ *            prettifiedPath: (string|undefined),
+ *            runtimeErrors: (Array.<BackendExtensionErrorObject>|undefined),
+ *            suspiciousInstall: boolean,
+ *            terminated: boolean,
+ *            version: string,
+ *            views: Array.<{renderViewId: number, renderProcessId: number,
+ *                path: string, incognito: boolean,
+ *                generatedBackgroundPage: boolean}>,
+ *            wantsAllUrls: boolean,
+ *            wantsErrorCollection: boolean,
+ *            wantsFileAccess: boolean,
+ *            warnings: (Array|undefined)}}
+ */
+var BackendExtensionDataObject;

[Dan Beam, 2014/08/21 18:27:48]

ExtensionData or ExtensionInfo

[Vitaly Pavlenko, 2014/08/22 01:43:40]

Done.

+
 cr.define('options', function() {
   'use strict';
 
   /**
    * Creates a new list of extensions.
    * @param {Object=} opt_propertyBag Optional properties.
    * @constructor
-   * @extends {cr.ui.div}
+   * @extends {HTMLDivElement}
    */
   var ExtensionsList = cr.ui.define('div');
 
   /**
    * @type {Object.<string, boolean>} A map from extension id to a boolean
    *     indicating whether the incognito warning is showing. This persists
    *     between calls to decorate.
    */
   var butterBarVisibility = {};
 
@@ skipping 41 matching lines @@
 
       if (this.data_.extensions.length == 0)
         this.classList.add('empty-extension-list');
       else
         this.classList.remove('empty-extension-list');
     },
 
     /**
      * Synthesizes and initializes an HTML element for the extension metadata
      * given in |extension|.
-     * @param {Object} extension A dictionary of extension metadata.
+     * @param {BackendExtensionDataObject} extension A dictionary of extension
+     *     metadata.
      * @private
      */
     createNode_: function(extension) {
       var template = $('template-collection').querySelector(
           '.extension-list-item-wrapper');
       var node = template.cloneNode(true);
       node.id = extension.id;
 
       if (!extension.enabled || extension.terminated)
         node.classList.add('inactive-extension');
@@ skipping 127 matching lines @@
                 extension.homepageProvided ? 'extensionSettingsVisitWebsite' :
                                              'extensionSettingsVisitWebStore');
         siteLink.hidden = false;
       }
 
       if (extension.allow_reload) {
         // The 'Reload' link.
         var reload = node.querySelector('.reload-link');
         reload.addEventListener('click', function(e) {
           chrome.send('extensionSettingsReload', [extension.id]);
-          extensionReloadedTimestamp[extension.id] = Date.now();
+          extensionReloadedTimestamp[extension.id] = String(Date.now());

[Dan Beam, 2014/08/21 18:27:47]

why do you need this?

[Vitaly Pavlenko, 2014/08/22 01:43:40]

Don't need actually, removed. I also fixed the type of
extensionReloadedTimestamp:
Object.<string, number> -> Object.<string, string>

[Dan Beam, 2014/08/22 21:57:13]

i assume you mean the other way around

         });
         reload.hidden = false;
 
         if (extension.is_platform_app) {
           // The 'Launch' link.
           var launch = node.querySelector('.launch-link');
           launch.addEventListener('click', function(e) {
             chrome.send('extensionSettingsLaunch', [extension.id]);
           });
           launch.hidden = false;
@@ skipping 162 matching lines @@
           li.innerText = warning.message;
           list.appendChild(li);
         });
       }
 
       this.appendChild(node);
       if (location.hash.substr(1) == extension.id) {
         // Scroll beneath the fixed header so that the extension is not
         // obscured.
         var topScroll = node.offsetTop - $('page-header').offsetHeight;
-        var pad = parseInt(getComputedStyle(node, null).marginTop, 10);
+        var pad = parseInt(window.getComputedStyle(node, null).marginTop, 10);
         if (!isNaN(pad))
           topScroll -= pad / 2;
         setScrollTopForDocument(document, topScroll);
       }
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });