Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 475633006: Typecheck JS files for chrome://extensions (Closed)

Created:
6 years, 4 months ago by Vitaly Pavlenko
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, dcheng, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@D_asserts_codingconvention
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/405253b7ee22ecb318d3c1ca9187e1e7259e704f Cr-Commit-Position: refs/heads/master@{#292195}

Patch Set 1 #

Patch Set 2 : looked twice #

Total comments: 52

Patch Set 3 : fixed issues #

Total comments: 22

Patch Set 4 : more fixes #

Patch Set 5 : fixed OptionsWebUIExtendedTest.OverlayBackToUnrelated #

Patch Set 6 : fixed failures (hope so) #

Total comments: 2

Patch Set 7 : fixed more test fails #

Patch Set 8 : creepy, kooky include hack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -180 lines) Patch
M chrome/browser/resources/extensions/chromeos/kiosk_app_list.js View 1 2 3 3 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/resources/extensions/chromeos/kiosk_apps.js View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/resources/extensions/compiled_resources.gyp View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/extensions/extension_code.js View 1 2 2 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/resources/extensions/extension_command_list.js View 1 2 14 chunks +24 lines, -13 lines 0 comments Download
M chrome/browser/resources/extensions/extension_commands_overlay.js View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/extensions/extension_error.js View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/extensions/extension_error_overlay.js View 1 2 3 17 chunks +65 lines, -35 lines 0 comments Download
M chrome/browser/resources/extensions/extension_list.js View 1 2 3 4 5 chunks +58 lines, -4 lines 0 comments Download
M chrome/browser/resources/extensions/extension_loader.js View 1 2 3 7 chunks +22 lines, -15 lines 0 comments Download
M chrome/browser/resources/extensions/extension_options_overlay.js View 1 2 3 4 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 1 2 3 5 chunks +17 lines, -3 lines 0 comments Download
M chrome/browser/resources/extensions/pack_extension_overlay.js View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 5 6 7 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/browser/extension_error.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ui/webui/resources/js/cr/event_target.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/alert_overlay.js View 1 2 3 2 chunks +15 lines, -15 lines 0 comments Download
M ui/webui/resources/js/cr/ui/array_data_model.js View 1 2 3 4 5 6 7 9 chunks +18 lines, -13 lines 0 comments Download
M ui/webui/resources/js/cr/ui/drag_wrapper.js View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/js/cr/ui/grid.js View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M ui/webui/resources/js/cr/ui/list.js View 1 2 3 4 5 6 14 chunks +32 lines, -31 lines 0 comments Download
M ui/webui/resources/js/cr/ui/list_item.js View 1 2 3 chunks +1 line, -4 lines 0 comments Download
M ui/webui/resources/js/cr/ui/list_selection_controller.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/list_selection_model.js View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 39 (0 generated)
Vitaly Pavlenko
6 years, 4 months ago (2014-08-19 01:34:07 UTC) #1
Dan Beam
will review this tonight if i have time, sorry for lagging
6 years, 4 months ago (2014-08-21 00:12:23 UTC) #2
Dan Beam
in general i'm not sure i like the Backend* prefix, as chrome is only a ...
6 years, 4 months ago (2014-08-21 18:27:48 UTC) #3
Vitaly Pavlenko
https://codereview.chromium.org/475633006/diff/20001/chrome/browser/resources/extensions/extension_code.js File chrome/browser/resources/extensions/extension_code.js (right): https://codereview.chromium.org/475633006/diff/20001/chrome/browser/resources/extensions/extension_code.js#newcode8 chrome/browser/resources/extensions/extension_code.js:8: * highlight:string, On 2014/08/21 18:27:47, Dan Beam wrote: > ...
6 years, 4 months ago (2014-08-22 01:43:41 UTC) #4
Dan Beam
https://codereview.chromium.org/475633006/diff/20001/chrome/browser/resources/extensions/extension_list.js File chrome/browser/resources/extensions/extension_list.js (right): https://codereview.chromium.org/475633006/diff/20001/chrome/browser/resources/extensions/extension_list.js#newcode279 chrome/browser/resources/extensions/extension_list.js:279: extensionReloadedTimestamp[extension.id] = String(Date.now()); On 2014/08/22 01:43:40, Vitaly Pavlenko wrote: ...
6 years, 4 months ago (2014-08-22 21:57:14 UTC) #5
Vitaly Pavlenko
https://codereview.chromium.org/475633006/diff/40001/chrome/browser/resources/extensions/chromeos/kiosk_app_list.js File chrome/browser/resources/extensions/chromeos/kiosk_app_list.js (right): https://codereview.chromium.org/475633006/diff/40001/chrome/browser/resources/extensions/chromeos/kiosk_app_list.js#newcode15 chrome/browser/resources/extensions/chromeos/kiosk_app_list.js:15: var BackendAppDataObject; On 2014/08/22 21:57:13, Dan Beam wrote: > ...
6 years, 4 months ago (2014-08-23 00:59:03 UTC) #6
Dan Beam
lgtm
6 years, 4 months ago (2014-08-23 01:10:34 UTC) #7
Vitaly Pavlenko
The CQ bit was checked by vitalyp@chromium.org
6 years, 4 months ago (2014-08-23 03:27:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/475633006/60001
6 years, 4 months ago (2014-08-23 04:56:23 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-23 09:28:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-23 09:33:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6234)
6 years, 4 months ago (2014-08-23 09:33:48 UTC) #12
Dan Beam
+kalman for extensions/OWNERS
6 years, 4 months ago (2014-08-25 16:48:20 UTC) #13
not at google - send to devlin
epic. lgtm.
6 years, 4 months ago (2014-08-25 20:37:07 UTC) #14
Vitaly Pavlenko
The CQ bit was checked by vitalyp@chromium.org
6 years, 3 months ago (2014-08-26 19:33:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/475633006/80001
6 years, 3 months ago (2014-08-26 19:34:20 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-26 21:08:29 UTC) #17
Vitaly Pavlenko
The CQ bit was unchecked by vitalyp@chromium.org
6 years, 3 months ago (2014-08-26 21:10:14 UTC) #18
Vitaly Pavlenko
The CQ bit was checked by vitalyp@chromium.org
6 years, 3 months ago (2014-08-27 00:48:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/475633006/100001
6 years, 3 months ago (2014-08-27 00:50:15 UTC) #20
Dan Beam
https://codereview.chromium.org/475633006/diff/100001/ui/webui/resources/js/cr/ui/list.js File ui/webui/resources/js/cr/ui/list.js (right): https://codereview.chromium.org/475633006/diff/100001/ui/webui/resources/js/cr/ui/list.js#newcode408 ui/webui/resources/js/cr/ui/list.js:408: if (!dataModel || !dataModel.length) slgtm - next time add ...
6 years, 3 months ago (2014-08-27 01:38:52 UTC) #21
Dan Beam
lgtm (Y U NO WORK?)
6 years, 3 months ago (2014-08-27 01:39:09 UTC) #22
Vitaly Pavlenko
The CQ bit was unchecked by vitalyp@chromium.org
6 years, 3 months ago (2014-08-27 02:21:29 UTC) #23
Vitaly Pavlenko
https://codereview.chromium.org/475633006/diff/100001/ui/webui/resources/js/cr/ui/list.js File ui/webui/resources/js/cr/ui/list.js (right): https://codereview.chromium.org/475633006/diff/100001/ui/webui/resources/js/cr/ui/list.js#newcode408 ui/webui/resources/js/cr/ui/list.js:408: if (!dataModel || !dataModel.length) On 2014/08/27 01:38:51, Dan Beam ...
6 years, 3 months ago (2014-08-27 03:08:34 UTC) #24
Vitaly Pavlenko
The CQ bit was checked by vitalyp@chromium.org
6 years, 3 months ago (2014-08-27 03:08:40 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/475633006/120001
6 years, 3 months ago (2014-08-27 03:09:42 UTC) #26
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 04:07:11 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 04:53:07 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/8294)
6 years, 3 months ago (2014-08-27 04:53:08 UTC) #29
Vitaly Pavlenko
The CQ bit was checked by vitalyp@chromium.org
6 years, 3 months ago (2014-08-27 17:56:22 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/475633006/140001
6 years, 3 months ago (2014-08-27 17:56:58 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 18:52:29 UTC) #32
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 18:52:30 UTC) #33
eroman
eroman@chromium.org changed reviewers: + eroman@chromium.org
6 years, 3 months ago (2014-08-27 19:48:46 UTC) #34
eroman
It looks like this caused a build failure in check liscences: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Builder%20%28dbg%29&number=64664
6 years, 3 months ago (2014-08-27 19:48:46 UTC) #35
Vitaly Pavlenko
On 2014/08/27 19:48:46, eroman wrote: > It looks like this caused a build failure in ...
6 years, 3 months ago (2014-08-27 20:04:18 UTC) #36
eroman
Don't know. Just noticed it is complaining about the file that was added here :)
6 years, 3 months ago (2014-08-27 20:13:51 UTC) #37
Vitaly Pavlenko
On 2014/08/27 20:13:51, eroman wrote: > Don't know. Just noticed it is complaining about the ...
6 years, 3 months ago (2014-08-27 20:20:31 UTC) #38
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:06 UTC) #39
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/405253b7ee22ecb318d3c1ca9187e1e7259e704f
Cr-Commit-Position: refs/heads/master@{#292195}

Powered by Google App Engine
This is Rietveld 408576698