Pass TouchMajor to HitTestResult

android_webview/renderer/aw_render_view_ext.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/renderer/aw_render_view_ext.h"
 
 #include <string>
 
 #include "android_webview/common/aw_hit_test_data.h"
 #include "android_webview/common/render_view_messages.h"
@@ skipping 248 matching lines @@
         GetAbsoluteSrcUrl(child_img);
   }
 
   PopulateHitTestData(absolute_link_url,
                       absolute_image_url,
                       render_view()->IsEditableNode(node),
                       &data);
   Send(new AwViewHostMsg_UpdateHitTestData(routing_id(), data));
 }
 
-void AwRenderViewExt::OnDoHitTest(int view_x, int view_y) {
+void AwRenderViewExt::OnDoHitTest(int view_x,
+                                  int view_y,
+                                  float touch_major_0,
+                                  float touch_major_1) {
   if (!render_view() || !render_view()->GetWebView())
     return;
 
+  // touch_major_1 refers to the touch area radius of the 2nd finger, if there
+  // are 2 fingers touching
+  // the screen. Some devices can report multiple movement traces at the same
+  // time, but not all.
+  // This follows what WebInputEventUtil::CreateWebTouchPoint is doing.
+  int radius = 0.5f * std::max(touch_major_0, touch_major_1);

[boliu, 2014/08/14 16:36:53]

hmm, should we do max or min here...?

[jdduke (slow), 2014/08/14 17:01:57]

Sorry for the drive-by, but why put this max logic in the renderer? Also, this
doesn't follow what WebInputEventUtil::CreateWebTouchPoint is doing, as that
method only uses the touch_major value for a single point.  

Why not pass in a rect, or the (x,y) and (width,height)?  It also seems a bit
odd to pass in multiple touch major values; shouldn't we pass the value
corresponding to the pointer at (|view_x|, |view_y|)?

[hush (inactive), 2014/08/14 17:03:32]

Sorry. I'm probably just doing a random thing here. If there are 2 fingers
touching the screen, HitTestResult behaviour will be pretty much undefined
right? Like what if one finger is touching a link and the other is touching an
image, what is hitTestResult supposed to return?

On 2014/08/14 16:36:53, boliu wrote:

[boliu, 2014/08/14 17:05:18]

Use the first point here.

[hush (inactive), 2014/08/14 17:25:22]

Thanks Jared for the comments! By "following what
WebInputEventUtil::CreateWebTouchPoint" is doing, I just meant taking half of
radius and creating a blink touch event.
Right, it is odd to pass in multiple touch major values. I will just use the
first touch major value as Bo suggested. Android WebView's getHitTestResult API
probably assumes there is only one touch major anyway.
On 2014/08/14 17:01:57, jdduke wrote:

+  const blink::WebSize touch_area(radius, radius);
   const blink::WebHitTestResult result =
       render_view()->GetWebView()->hitTestResultAt(
-          blink::WebPoint(view_x, view_y));
+          blink::WebPoint(view_x, view_y), touch_area);
   AwHitTestData data;
 
   if (!result.urlElement().isNull()) {
     data.anchor_text = result.urlElement().innerText();
     data.href = GetHref(result.urlElement());
   }
 
   PopulateHitTestData(result.absoluteLinkURL(),
                       result.absoluteImageURL(),
                       result.isContentEditable(),
@@ skipping 28 matching lines @@
   render_view()->GetWebView()->setFixedLayoutSize(size);
 }
 
 void AwRenderViewExt::OnSetBackgroundColor(SkColor c) {
   if (!render_view() || !render_view()->GetWebView())
     return;
   render_view()->GetWebView()->setBaseBackgroundColor(c);
 }
 
 }  // namespace android_webview