Pass TouchMajor to HitTestResult

android_webview/renderer/aw_render_view_ext.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/renderer/aw_render_view_ext.h"
 
 #include <string>
 
 #include "android_webview/common/aw_hit_test_data.h"
 #include "android_webview/common/render_view_messages.h"
@@ skipping 247 matching lines @@
         GetAbsoluteSrcUrl(child_img);
   }
 
   PopulateHitTestData(absolute_link_url,
                       absolute_image_url,
                       render_view()->IsEditableNode(node),
                       &data);
   Send(new AwViewHostMsg_UpdateHitTestData(routing_id(), data));
 }
 
-void AwRenderViewExt::OnDoHitTest(int view_x, int view_y) {
+void AwRenderViewExt::OnDoHitTest(int view_x, int view_y, float touch_major) {
   if (!render_view() || !render_view()->GetWebView())
     return;
 
+  // Using half of touch major as the radius. This follows what
+  // WebInputEventUtil::CreateWebTouchPoint is doing.
+  int radius = 0.5f * touch_major;
+  const blink::WebSize touch_area(radius, radius);

[jdduke (slow), 2014/10/28 23:08:04]

We shouldn't be using a radius here. Radii are only used with touch events
because that's how their members are exposed to the web; tap/press events use a
regular bounding box (width/height) for hit testing.

[hush (inactive), 2014/10/30 00:25:19]

Instead of passing touch_major, I will pass both the touch major and touch
minor. (both included in a RectF)
And use half of touch major as the width and half of touch minor as the height.

   const blink::WebHitTestResult result =
-      render_view()->GetWebView()->hitTestResultAt(
-          blink::WebPoint(view_x, view_y));
+      render_view()->GetWebView()->hitTestResultForTap(

[hush (inactive), 2014/10/28 22:57:45]

I only changed here in PS4. Others are just rebase.

The blink CL will land first, then this one, then another CL to remove
hitTestResultAt from blink::WebView API.

+          blink::WebPoint(view_x, view_y), touch_area);
   AwHitTestData data;
 
   if (!result.urlElement().isNull()) {
     data.anchor_text = result.urlElement().innerText();
     data.href = GetHref(result.urlElement());
   }
 
   PopulateHitTestData(result.absoluteLinkURL(),
                       result.absoluteImageURL(),
                       result.isContentEditable(),
@@ skipping 22 matching lines @@
       page_scale_factor);
 }
 
 void AwRenderViewExt::OnSetBackgroundColor(SkColor c) {
   if (!render_view() || !render_view()->GetWebView())
     return;
   render_view()->GetWebView()->setBaseBackgroundColor(c);
 }
 
 }  // namespace android_webview