Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 475543005: Re-enable ServiceWorkerBrowserTest.Reload except for Android (Closed)

Created:
6 years, 4 months ago by horo
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enable ServiceWorkerBrowserTest.Reload except for Android According to http://chromium-build-logs.appspot.com/gtest_query?gtest_query=ServiceWorkerBrowserTest.Reload this test failed only on Android after r288301. BUG=393486 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
horo
Could you please review?
6 years, 4 months ago (2014-08-14 09:05:28 UTC) #1
falken
The CQ bit was checked by falken@chromium.org
6 years, 4 months ago (2014-08-14 10:59:41 UTC) #2
falken
lgtm
6 years, 4 months ago (2014-08-14 10:59:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/475543005/1
6 years, 4 months ago (2014-08-14 11:03:17 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 16:12:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 289610

Powered by Google App Engine
This is Rietveld 408576698