chrome/common/extensions/api/_api_features.json - Issue 475543003: Display extension options in a WebUI overlay instead of in a new tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/_api_features.json

Issue 475543003: Display extension options in a WebUI overlay instead of in a new tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/extensions/extension_options_overlay.js ('K') | « chrome/browser/resources/extensions/extensions.js ('k') | chrome/renderer/resources/extensions/extension_options.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/_api_features.json

diff --git a/chrome/common/extensions/api/_api_features.json b/chrome/common/extensions/api/_api_features.json

index d0ebe4fda602ebe612149906a3e4e71907c4ee16..3919c441abd4b80731ba8873d190561ff3afcf02 100644

--- a/chrome/common/extensions/api/_api_features.json

+++ b/chrome/common/extensions/api/_api_features.json

@@ -213,10 +213,14 @@

"dependencies": ["permission:cloudPrintPrivate"],

"contexts": ["blessed_extension"]

- "commandLinePrivate": {

+ "commandLinePrivate": [{

"dependencies": ["permission:commandLinePrivate"],

"contexts": ["blessed_extension"]

- },

+ }, {

+ "channel": "stable",

+ "contexts": ["webui"],

+ "matches": ["chrome://extensions-frame/*", "chrome://extensions/*"]

+ }],

"commands": {

"dependencies": ["manifest:commands"],

"contexts": ["blessed_extension"]