chrome/browser/resources/extensions/extension_list.js - Issue 475543003: Display extension options in a WebUI overlay instead of in a new tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 475543003: Display extension options in a WebUI overlay instead of in a new tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/extensions/extension_options_overlay.html » ('j') | chrome/browser/resources/extensions/extension_options_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extension_list.js

diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js

index 7067da5d00362dd398a95e914e17ca357a3a74ea..8e830a683d05df332aa85eec056675020ae331e7 100644

--- a/chrome/browser/resources/extensions/extension_list.js

+++ b/chrome/browser/resources/extensions/extension_list.js

@@ -193,7 +193,15 @@ cr.define('options', function() {

if (extension.enabled && extension.optionsUrl) {

var options = node.querySelector('.options-link');

options.addEventListener('click', function(e) {

- chrome.send('extensionSettingsOptions', [extension.id]);

+ chrome.commandLinePrivate.hasSwitch(

+ 'enable-embedded-extension-options', function(result) {

+ if (result) {

+ extensions.ExtensionOptionsOverlay.getInstance()

+ .setExtensionAndShowOverlay([extension.id], extension.name);

+ } else {

+ chrome.send('extensionSettingsOptions', [extension.id]);

+ }

+ });

e.preventDefault();

});

options.hidden = false;