Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3694)

Unified Diff: chrome/renderer/resources/extensions/extension_options.js

Issue 475543003: Display extension options in a WebUI overlay instead of in a new tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/extension_options.js
diff --git a/chrome/renderer/resources/extensions/extension_options.js b/chrome/renderer/resources/extensions/extension_options.js
index 854b550e19a1040efe2408a71a5bef43eec361a7..d88c3d1460a5bd490e6ba0ba423f1c3f03bf0863 100644
--- a/chrome/renderer/resources/extensions/extension_options.js
+++ b/chrome/renderer/resources/extensions/extension_options.js
@@ -13,10 +13,10 @@ var utils = require('utils');
// Mapping of the autosize attribute names to default values
var AUTO_SIZE_ATTRIBUTES = {
'autosize': 'on',
- 'maxheight': 600,
- 'maxwidth': 800,
+ 'maxheight': window.innerHeight,
+ 'maxwidth': window.innerWidth,
'minheight': 32,
- 'minwidth': 80
+ 'minwidth': 32
};
function ExtensionOptionsInternal(extensionoptionsNode) {

Powered by Google App Engine
This is Rietveld 408576698