Display extension options in a WebUI overlay instead of in a new tab

chrome/browser/resources/extensions/extension_list.js

Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 1271b28de19ca8a14fa504ed02fdbd347d26d167..08fb75e0ad1412d505af64b9625c3ff909b23254 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -193,9 +193,14 @@ cr.define('options', function() {
       if (extension.enabled && extension.optionsUrl) {
         var options = node.querySelector('.options-link');
         options.addEventListener('click', function(e) {
-          chrome.send('extensionSettingsOptions', [extension.id]);
+          if (this.data_.enableEmbeddedExtensionOptions) {
+            extensions.ExtensionOptionsOverlay.getInstance().
+                setExtensionAndShowOverlay([extension.id], extension.name);

[Vitaly Pavlenko, 2014/08/21 22:46:21]

setExtensionAndShowOverlay() gets {string} as first parameter. Please, fix the
call here or the JSDoc in extension_options_overlay.js

+          } else {
+            chrome.send('extensionSettingsOptions', [extension.id]);
+          }
           e.preventDefault();
-        });
+        }.bind(this));
         options.hidden = false;
       }