Display extension options in a WebUI overlay instead of in a new tab

chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index e8c5110ce1d4c78a4a7f1e1aa0129c686ef1ff3e..9a8c4ce14421dcf73a3764bf019c3f169a8629fe 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -91,6 +91,7 @@
 #include "extensions/common/manifest_handlers/background_info.h"
 #include "extensions/common/manifest_handlers/incognito_info.h"
 #include "extensions/common/permissions/permissions_data.h"
+#include "extensions/common/switches.h"
 #include "grit/browser_resources.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
@@ -878,6 +879,11 @@ void ExtensionSettingsHandler::HandleRequestExtensionsData(
       ExtensionPrefs::Get(profile)->ExtensionsBlacklistedByDefault();
   results.SetBoolean("loadUnpackedDisabled", load_unpacked_disabled);
 
+  CommandLine* command_line = CommandLine::ForCurrentProcess();
+  results.SetBoolean(
+      "enableEmbeddedExtensionOptions",
+      command_line->HasSwitch(switches::kEnableEmbeddedExtensionOptions));

[Devlin, 2014/08/18 17:28:04]

nit: prefer feature switch use.

[ericzeng, 2014/08/18 18:00:25]

Done.

+
   web_ui()->CallJavascriptFunction(
       "extensions.ExtensionSettings.returnExtensionsData", results);