chrome/renderer/resources/extensions/extension_options.js - Issue 475543003: Display extension options in a WebUI overlay instead of in a new tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/extension_options.js

Issue 475543003: Display extension options in a WebUI overlay instead of in a new tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/extensions/extension_options.js

diff --git a/chrome/renderer/resources/extensions/extension_options.js b/chrome/renderer/resources/extensions/extension_options.js

index 854b550e19a1040efe2408a71a5bef43eec361a7..3e62c4e92d8d29d1e92ebf619621d3c5ad636e49 100644

--- a/chrome/renderer/resources/extensions/extension_options.js

+++ b/chrome/renderer/resources/extensions/extension_options.js

@@ -13,10 +13,10 @@ var utils = require('utils');

// Mapping of the autosize attribute names to default values

var AUTO_SIZE_ATTRIBUTES = {

'autosize': 'on',

- 'maxheight': 600,

- 'maxwidth': 800,

+ 'maxheight': 1080,

+ 'maxwidth': 1920,

'minheight': 32,

- 'minwidth': 80

+ 'minwidth': 32

not at google - send to devlin 2014/08/14 15:33:21 Can we at least make these max values based on the

ericzeng 2014/08/14 18:11:54 Done.

};

function ExtensionOptionsInternal(extensionoptionsNode) {

« chrome/common/extensions/api/_api_features.json ('K') | « chrome/common/extensions/api/_api_features.json ('k') | no next file » | no next file with comments »