Display extension options in a WebUI overlay instead of in a new tab

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 cr.define('options', function() {
   'use strict';
 
   /**
@@ skipping 175 matching lines @@
                       [extension.id, String(e.target.checked)]);
         });
         fileAccess.querySelector('input').checked = extension.allowFileAccess;
         fileAccess.hidden = false;
       }
 
       // The 'Options' link.
       if (extension.enabled && extension.optionsUrl) {
         var options = node.querySelector('.options-link');
         options.addEventListener('click', function(e) {
-          chrome.send('extensionSettingsOptions', [extension.id]);
+          if (this.data_.enableEmbeddedExtensionOptions) {
+            extensions.ExtensionOptionsOverlay.getInstance().
+                setExtensionAndShowOverlay([extension.id], extension.name);

[Vitaly Pavlenko, 2014/08/21 22:46:21]

setExtensionAndShowOverlay() gets {string} as first parameter. Please, fix the
call here or the JSDoc in extension_options_overlay.js

+          } else {
+            chrome.send('extensionSettingsOptions', [extension.id]);
+          }
           e.preventDefault();
-        });
+        }.bind(this));
         options.hidden = false;
       }
 
       // The 'Permissions' link.
       var permissions = node.querySelector('.permissions-link');
       permissions.addEventListener('click', function(e) {
         chrome.send('extensionSettingsPermissions', [extension.id]);
         e.preventDefault();
       });
 
@@ skipping 200 matching lines @@
           topScroll -= pad / 2;
         setScrollTopForDocument(document, topScroll);
       }
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });