Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/renderer/resources/extensions/extension_options.js

Issue 475543003: Display extension options in a WebUI overlay instead of in a new tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var DocumentNatives = requireNative('document_natives'); 5 var DocumentNatives = requireNative('document_natives');
6 var ExtensionOptionsEvents = 6 var ExtensionOptionsEvents =
7 require('extensionOptionsEvents').ExtensionOptionsEvents; 7 require('extensionOptionsEvents').ExtensionOptionsEvents;
8 var GuestViewInternal = 8 var GuestViewInternal =
9 require('binding').Binding.create('guestViewInternal').generate(); 9 require('binding').Binding.create('guestViewInternal').generate();
10 var IdGenerator = requireNative('id_generator'); 10 var IdGenerator = requireNative('id_generator');
11 var utils = require('utils'); 11 var utils = require('utils');
12 12
13 // Mapping of the autosize attribute names to default values 13 // Mapping of the autosize attribute names to default values
14 var AUTO_SIZE_ATTRIBUTES = { 14 var AUTO_SIZE_ATTRIBUTES = {
15 'autosize': 'on', 15 'autosize': 'on',
16 'maxheight': 600, 16 'maxheight': 1080,
17 'maxwidth': 800, 17 'maxwidth': 1920,
18 'minheight': 32, 18 'minheight': 32,
19 'minwidth': 80 19 'minwidth': 32
not at google - send to devlin 2014/08/14 15:33:21 Can we at least make these max values based on the
ericzeng 2014/08/14 18:11:54 Done.
20 }; 20 };
21 21
22 function ExtensionOptionsInternal(extensionoptionsNode) { 22 function ExtensionOptionsInternal(extensionoptionsNode) {
23 privates(extensionoptionsNode).internal = this; 23 privates(extensionoptionsNode).internal = this;
24 this.extensionoptionsNode = extensionoptionsNode; 24 this.extensionoptionsNode = extensionoptionsNode;
25 this.viewInstanceId = IdGenerator.GetNextId(); 25 this.viewInstanceId = IdGenerator.GetNextId();
26 26
27 // on* Event handlers. 27 // on* Event handlers.
28 this.eventHandlers = {}; 28 this.eventHandlers = {};
29 29
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 264
265 var useCapture = true; 265 var useCapture = true;
266 window.addEventListener('readystatechange', function listener(event) { 266 window.addEventListener('readystatechange', function listener(event) {
267 if (document.readyState == 'loading') 267 if (document.readyState == 'loading')
268 return; 268 return;
269 269
270 registerBrowserPluginElement(); 270 registerBrowserPluginElement();
271 registerExtensionOptionsElement(); 271 registerExtensionOptionsElement();
272 window.removeEventListener(event.type, listener, useCapture); 272 window.removeEventListener(event.type, listener, useCapture);
273 }, useCapture); 273 }, useCapture);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698