Display extension options in a WebUI overlay instead of in a new tab

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 cr.define('options', function() {
   'use strict';
 
   /**
@@ skipping 175 matching lines @@
                       [extension.id, String(e.target.checked)]);
         });
         fileAccess.querySelector('input').checked = extension.allowFileAccess;
         fileAccess.hidden = false;
       }
 
       // The 'Options' link.
       if (extension.enabled && extension.optionsUrl) {
         var options = node.querySelector('.options-link');
         options.addEventListener('click', function(e) {
-          chrome.send('extensionSettingsOptions', [extension.id]);
+          chrome.commandLinePrivate.hasSwitch(

[Dan Beam, 2014/08/14 19:01:26]

^ why are we doing this in JS instead of in C++ and sending the result to JS?

[ericzeng, 2014/08/14 22:34:13]

Is there a convenient way to send the flags check down to C++? I haven't worked
in WebUI before so I'm not sure what the best way to do this is.

[Devlin, 2014/08/15 15:19:50]

Since this is in ExtensionsList, we could just set a new bool on the results
(which goes to ExtensionsList.data_).  For an example, look at what we do with
e.g. "incognitoAvailable" here and in extension_settings_handler.cc.

[not at google - send to devlin, 2014/08/15 15:51:06]

I kind of like this using an extension API :) less WebUI. But no big deal. One
disadvantage is that the switch might be missed if somebody is grepping through
removing it (though unlikely).

[ericzeng, 2014/08/15 18:05:25]

Done.

+              'enable-embedded-extension-options', function(result) {

[Dan Beam, 2014/08/14 19:01:26]

chrome.commandLinePrivate.hasSwitch(
    'enable-embedded-extension-options',
    function(result) {
  ...
});

or

chrome.commandLinePrivate.hasSwitch(
    'enable-embedded-extension-options',
    function(result) {
      ...
    });

[ericzeng, 2014/08/14 22:34:13]

Done.

+            if (result) {
+              extensions.ExtensionOptionsOverlay.getInstance()
+                  .setExtensionAndShowOverlay([extension.id], extension.name);

[Dan Beam, 2014/08/14 19:01:26]

dot at end:

extensions.ExtensionOptionsOverlay.getInstance().
    setExtensionAndShowOverlay(

[ericzeng, 2014/08/14 22:34:13]

Done.

+            } else {
+              chrome.send('extensionSettingsOptions', [extension.id]);
+            }
+          });
           e.preventDefault();
         });
         options.hidden = false;
       }
 
       // The 'Permissions' link.
       var permissions = node.querySelector('.permissions-link');
       permissions.addEventListener('click', function(e) {
         chrome.send('extensionSettingsPermissions', [extension.id]);
         e.preventDefault();
@@ skipping 199 matching lines @@
           topScroll -= pad / 2;
         setScrollTopForDocument(document, topScroll);
       }
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });