Issue 475533007: Minor ServiceWorker cleanup. The Registration.Clear method can potentially generated multiple listn…

Issue 475533007: Minor ServiceWorker cleanup. The Registration.Clear method can potentially generated multiple listn… (Closed)

Created:
6 years, 4 months ago by michaeln

Modified:
6 years, 4 months ago

Reviewers:
falken, nhiroki

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Minor ServiceWorker cleanup. The Registration.Clear method potentially generated multiple listnener notificatons. This CL consolidates them into at most one. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290641

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -11 lines)			Patch
	M	content/browser/service_worker/service_worker_registration.cc	View	1 2 3	1 chunk	+19 lines, -11 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

falken

DBC https://codereview.chromium.org/475533007/diff/20001/content/browser/service_worker/service_worker_registration.cc File content/browser/service_worker/service_worker_registration.cc (right): https://codereview.chromium.org/475533007/diff/20001/content/browser/service_worker/service_worker_registration.cc#newcode290 content/browser/service_worker/service_worker_registration.cc:290: active_version_->Doom(); I think you might have to call ...

6 years, 4 months ago (2014-08-19 01:00:21 UTC) #2

nhiroki

lgtm https://codereview.chromium.org/475533007/diff/20001/content/browser/service_worker/service_worker_registration.cc File content/browser/service_worker/service_worker_registration.cc (right): https://codereview.chromium.org/475533007/diff/20001/content/browser/service_worker/service_worker_registration.cc#newcode290 content/browser/service_worker/service_worker_registration.cc:290: active_version_->Doom(); I think we need to call "active_version_->RemoveListener(this);" ...

6 years, 4 months ago (2014-08-19 01:04:31 UTC) #3

michaeln

https://codereview.chromium.org/475533007/diff/20001/content/browser/service_worker/service_worker_registration.cc File content/browser/service_worker/service_worker_registration.cc (right): https://codereview.chromium.org/475533007/diff/20001/content/browser/service_worker/service_worker_registration.cc#newcode290 content/browser/service_worker/service_worker_registration.cc:290: active_version_->Doom(); thnx I think a call to active_version_->RemoveListener(this) should ...

6 years, 4 months ago (2014-08-19 02:36:11 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/475533007/60001

6 years, 4 months ago (2014-08-19 18:31:11 UTC) #6

commit-bot: I haz the power

6 years, 4 months ago (2014-08-19 20:05:16 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 (60001) as 290641

Expand Messages | Collapse Messages