Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 475533005: [ServiceWorker] Add support of FetchEvent's request.body. (Closed)

Created:
6 years, 4 months ago by horo
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, jamesr, tzik, serviceworker-reviews, nhiroki, abarth-chromium, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Add support of FetchEvent's request.body. This CL introduces Request.body, but it is only supported in FetchEvent. The followings are not supported yet. - Creating a new Request object with body in JavaScript. - Sending body with fetch API. This cl depends on https://codereview.chromium.org/475333002/. BUG=402387 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180641

Patch Set 1 : #

Total comments: 6

Patch Set 2 : incorporated falken's comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -26 lines) Patch
M LayoutTests/http/tests/serviceworker/fetch-event.html View 1 1 chunk +46 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js View 1 1 chunk +36 lines, -23 lines 0 comments Download
M Source/modules/serviceworkers/FetchRequestData.h View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/FetchRequestData.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/Request.h View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/Request.cpp View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/Request.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
horo
falken@ Could you please review?
6 years, 4 months ago (2014-08-18 12:04:12 UTC) #1
falken
lgtm. we haven't been disciplined about it, but we should clean up the junk added ...
6 years, 4 months ago (2014-08-19 04:08:25 UTC) #2
horo
https://codereview.chromium.org/475533005/diff/140001/LayoutTests/http/tests/serviceworker/fetch-event.html File LayoutTests/http/tests/serviceworker/fetch-event.html (right): https://codereview.chromium.org/475533005/diff/140001/LayoutTests/http/tests/serviceworker/fetch-event.html#newcode184 LayoutTests/http/tests/serviceworker/fetch-event.html:184: resolve(frame); On 2014/08/19 04:08:25, falken wrote: > can you ...
6 years, 4 months ago (2014-08-19 04:46:14 UTC) #3
horo
The CQ bit was checked by horo@chromium.org
6 years, 4 months ago (2014-08-20 09:41:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/475533005/200001
6 years, 4 months ago (2014-08-20 09:42:41 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 10:42:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (200001) as 180641

Powered by Google App Engine
This is Rietveld 408576698