Issue 475533003: Upstream changes to enable chunked uploads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 475533003: Upstream changes to enable chunked uploads. (Closed)

Created:
6 years, 4 months ago by mef

Modified:
6 years, 4 months ago

Reviewers:
mdumitrescu, miloslav, mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Upstream changes to enable chunked uploads. BUG=390267

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+209 lines, -2 lines)			Patch
M	components/cronet/android/chromium_url_request.cc	View	2 chunks	+30 lines, -0 lines	0 comments	Download
M	components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java	View	9 chunks	+135 lines, -0 lines	0 comments	Download
M	components/cronet/android/url_request_adapter.h	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	components/cronet/android/url_request_adapter.cc	View	4 chunks	+32 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mmenke

On 2014/08/14 21:14:20, mef wrote: Is this needed in addition to mdumitrescu's CL, or is ...

6 years, 4 months ago (2014-08-15 16:14:36 UTC) #2

mmenke

On 2014/08/15 16:14:36, mmenke wrote: > On 2014/08/14 21:14:20, mef wrote: > > Is this ...

6 years, 4 months ago (2014-08-15 16:14:56 UTC) #3

mdumitrescu

On 2014/08/15 16:14:56, mmenke wrote: > On 2014/08/15 16:14:36, mmenke wrote: > > On 2014/08/14 ...

6 years, 4 months ago (2014-08-15 16:16:09 UTC) #4

mef

6 years, 4 months ago (2014-08-15 16:17:29 UTC) #5

On 2014/08/15 16:14:56, mmenke wrote:
> On 2014/08/15 16:14:36, mmenke wrote:
> > On 2014/08/14 21:14:20, mef wrote:
> > 
> > Is this needed in addition to mdumitrescu's CL, or is mdumitrescu an
> alternative
> > to this?
> 
> (More simply...Should I review this?)

This is an alternative to mdumitrescu's CL and I think it is better to continue
with his CL as he has better understanding of their use case.
I'll close this CL, no need to review.

Expand Messages | Collapse Messages