Set focused TextInputType to the Ime extension

Set focused TextInputType to the Ime extension.

Input elements typed "text", "search", "tel", "url", "email"　 and "number" are text input field: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#attr-input-type

context.type should represent those types. 

BUG=311514
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233521

[yoichio, 2013-10-30 03:47:09]

Could you take a look?

[Seigo Nonaka, 2013-10-30 04:00:00]

lgtm with nit.

https://codereview.chromium.org/47553010/diff/1/chrome/browser/chromeos/input...
File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right):

https://codereview.chromium.org/47553010/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:420: case
ibus::TEXT_INPUT_TYPE_SEARCH:
nit: need two-space indent.

https://codereview.chromium.org/47553010/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/input_ime.json (right):

https://codereview.chromium.org/47553010/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/input_ime.json:32: "type": {"type": "string",
"description": "Type of value this text field edits, (Text, Number, Password,
etc)", "enum": ["text", "search", "tel", "url", "email", "password", "number"]}
Please drop "password" from this, input method framework does not forward
keyboard event on password field.

[yoichio, 2013-10-30 05:32:22]

https://codereview.chromium.org/47553010/diff/1/chrome/browser/chromeos/input...
File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right):

https://codereview.chromium.org/47553010/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:420: case
ibus::TEXT_INPUT_TYPE_SEARCH:
On 2013/10/30 04:00:00, Seigo Nonaka wrote:
> nit: need two-space indent.

Done.

https://codereview.chromium.org/47553010/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/input_ime.json (right):

https://codereview.chromium.org/47553010/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/input_ime.json:32: "type": {"type": "string",
"description": "Type of value this text field edits, (Text, Number, Password,
etc)", "enum": ["text", "search", "tel", "url", "email", "password", "number"]}
On 2013/10/30 04:00:00, Seigo Nonaka wrote:
> Please drop "password" from this, input method framework does not forward
> keyboard event on password field.

Done.

[commit-bot: I haz the power, 2013-10-30 07:21:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/47553010/110001

[commit-bot: I haz the power, 2013-10-30 07:34:42]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[yoichio, 2013-10-30 07:41:26]

Add kalman@ as an OWNER for chrome/common/extensions/api/input_ime.json.

The change to the file is to modify enum.
Could you review?

[not at google - send to devlin, 2013-10-30 13:58:31]

https://codereview.chromium.org/47553010/diff/110001/chrome/common/extensions...
File chrome/common/extensions/api/input_ime.json (right):

https://codereview.chromium.org/47553010/diff/110001/chrome/common/extensions...
chrome/common/extensions/api/input_ime.json:32: "type": {"type": "string",
"description": "Type of value this text field edits, (Text, Number, URL, etc)",
"enum": ["text", "search", "tel", "url", "email", "number"]}
what happened to password?

[yoichio, 2013-10-31 01:31:52]

On 2013/10/30 13:58:31, kalman wrote:
>
https://codereview.chromium.org/47553010/diff/110001/chrome/common/extensions...
> File chrome/common/extensions/api/input_ime.json (right):
> 
>
https://codereview.chromium.org/47553010/diff/110001/chrome/common/extensions...
> chrome/common/extensions/api/input_ime.json:32: "type": {"type": "string",
> "description": "Type of value this text field edits, (Text, Number, URL,
etc)",
> "enum": ["text", "search", "tel", "url", "email", "number"]}
> what happened to password?

The input method framework does not forward events on a password field to the
IME extension.
So the password enum doesn't make sense.

[not at google - send to devlin, 2013-10-31 02:40:30]

https://codereview.chromium.org/47553010/diff/110001/chrome/common/extensions...
File chrome/common/extensions/api/input_ime.json (right):

https://codereview.chromium.org/47553010/diff/110001/chrome/common/extensions...
chrome/common/extensions/api/input_ime.json:32: "type": {"type": "string",
"description": "Type of value this text field edits, (Text, Number, URL, etc)",
"enum": ["text", "search", "tel", "url", "email", "number"]}
On 2013/10/30 13:58:31, kalman wrote:
> what happened to password?

It's already in the API though, you can't remove it.

[yoichio, 2013-10-31 03:05:40]

https://codereview.chromium.org/47553010/diff/110001/chrome/common/extensions...
File chrome/common/extensions/api/input_ime.json (right):

https://codereview.chromium.org/47553010/diff/110001/chrome/common/extensions...
chrome/common/extensions/api/input_ime.json:32: "type": {"type": "string",
"description": "Type of value this text field edits, (Text, Number, URL, etc)",
"enum": ["text", "search", "tel", "url", "email", "number"]}
On 2013/10/31 02:40:30, kalman wrote:
> On 2013/10/30 13:58:31, kalman wrote:
> > what happened to password?
> 
> It's already in the API though, you can't remove it.

Even if it is never used?

[not at google - send to devlin, 2013-10-31 14:59:58]

lgtm

https://codereview.chromium.org/47553010/diff/110001/chrome/common/extensions...
File chrome/common/extensions/api/input_ime.json (right):

https://codereview.chromium.org/47553010/diff/110001/chrome/common/extensions...
chrome/common/extensions/api/input_ime.json:32: "type": {"type": "string",
"description": "Type of value this text field edits, (Text, Number, URL, etc)",
"enum": ["text", "search", "tel", "url", "email", "number"]}
On 2013/10/31 03:05:41, yoichio wrote:
> On 2013/10/31 02:40:30, kalman wrote:
> > On 2013/10/30 13:58:31, kalman wrote:
> > > what happened to password?
> > 
> > It's already in the API though, you can't remove it.
> 
> Even if it is never used?

It probably doesn't matter come to think about it, because this data is coming
from the browser, so that if an extension does try to handle 'password' here at
least it won't break. If the extension were passing 'password' in anywhere then
it'd need to stay.

[yoichio, 2013-10-31 21:50:39]

On 2013/10/31 14:59:58, kalman wrote:
> lgtm
> 
>
https://codereview.chromium.org/47553010/diff/110001/chrome/common/extensions...
> File chrome/common/extensions/api/input_ime.json (right):
> 
>
https://codereview.chromium.org/47553010/diff/110001/chrome/common/extensions...
> chrome/common/extensions/api/input_ime.json:32: "type": {"type": "string",
> "description": "Type of value this text field edits, (Text, Number, URL,
etc)",
> "enum": ["text", "search", "tel", "url", "email", "number"]}
> On 2013/10/31 03:05:41, yoichio wrote:
> > On 2013/10/31 02:40:30, kalman wrote:
> > > On 2013/10/30 13:58:31, kalman wrote:
> > > > what happened to password?
> > > 
> > > It's already in the API though, you can't remove it.
> > 
> > Even if it is never used?
> 
> It probably doesn't matter come to think about it, because this data is coming
> from the browser, so that if an extension does try to handle 'password' here
at
> least it won't break. If the extension were passing 'password' in anywhere
then
> it'd need to stay.

Thanks! 
Yes, the "context.type" value is only passed from the browser to the extension.

[commit-bot: I haz the power, 2013-10-31 23:26:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/47553010/110001

[commit-bot: I haz the power, 2013-11-06 02:18:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/47553010/110001

[commit-bot: I haz the power, 2013-11-06 04:49:03]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-06 11:42:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/47553010/110001

[commit-bot: I haz the power, 2013-11-06 15:13:02]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-07 02:42:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/47553010/110001

[commit-bot: I haz the power, 2013-11-07 06:37:31]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-11-07 06:57:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/47553010/110001

[commit-bot: I haz the power, 2013-11-07 07:03:53]

Change committed as 233521