Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: content/common/gpu/media/exynos_video_decode_accelerator.cc

Issue 47553003: Revert "Exynos decoder: workaround for wrong MFC output format." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/media/exynos_video_decode_accelerator.cc
diff --git a/content/common/gpu/media/exynos_video_decode_accelerator.cc b/content/common/gpu/media/exynos_video_decode_accelerator.cc
index d18477718cd0400ab09b580999141b44f01572c1..d6646d14219ceb2d538a0b9e19fed7fc7b22bc74 100644
--- a/content/common/gpu/media/exynos_video_decode_accelerator.cc
+++ b/content/common/gpu/media/exynos_video_decode_accelerator.cc
@@ -398,12 +398,10 @@ bool ExynosVideoDecodeAccelerator::Initialize(
return false;
// MFC output format has to be setup before streaming starts.
- // TODO(hshi): set format back to tiled (V4L2_PIX_FMT_NV12MT_16X16) when we
- // fix the underlying driver/firmware issue. http://crbug.com/303300.
struct v4l2_format format;
memset(&format, 0, sizeof(format));
format.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
- format.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_NV12M;
+ format.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_NV12MT_16X16;
Ami GONE FROM CHROMIUM 2013/10/28 15:03:41 Does this improve perf? (why is NV12MT_16x16 bett
sheu 2013/10/28 17:24:49 MT16x16 is a tiled format, and NV12M is plain line
IOCTL_OR_ERROR_RETURN_FALSE(mfc_fd_, VIDIOC_S_FMT, &format);
// Subscribe to the resolution change event.
@@ -2113,7 +2111,7 @@ bool ExynosVideoDecodeAccelerator::CreateBuffersForFormat(
mfc_output_buffer_size_[0] = format.fmt.pix_mp.plane_fmt[0].sizeimage;
mfc_output_buffer_size_[1] = format.fmt.pix_mp.plane_fmt[1].sizeimage;
mfc_output_buffer_pixelformat_ = format.fmt.pix_mp.pixelformat;
- DCHECK_EQ(mfc_output_buffer_pixelformat_, V4L2_PIX_FMT_NV12M);
+ DCHECK_EQ(mfc_output_buffer_pixelformat_, V4L2_PIX_FMT_NV12MT_16X16);
DVLOG(3) << "CreateBuffersForFormat(): new resolution: "
<< frame_buffer_size_.ToString();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698