Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: Tools/TestResultServer/model/jsonresults.py

Issue 475503005: Handle tries of results data in upload (fix _is_directory). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add a test, fix unrelated failing unittest Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
11 # in the documentation and/or other materials provided with the 11 # in the documentation and/or other materials provided with the
12 # distribution. 12 # distribution.
13 # * Neither the name of Google Inc. nor the names of its 13 # * Neither the name of Google Inc. nor the names of its
14 # contributors may be used to endorse or promote products derived from 14 # contributors may be used to endorse or promote products derived from
15 # this software without specific prior written permission. 15 # this software without specific prior written permission.
16 # 16 #
17 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 17 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
18 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 18 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
19 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 19 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
20 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 20 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
21 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 21 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
22 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 22 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 28
29 import collections
29 import json 30 import json
30 import logging 31 import logging
31 import re 32 import re
32 import sys 33 import sys
33 import traceback 34 import traceback
34 35
35 from testfile import TestFile 36 from testfile import TestFile
36 37
37 JSON_RESULTS_FILE = "results.json" 38 JSON_RESULTS_FILE = "results.json"
38 JSON_RESULTS_FILE_SMALL = "results-small.json" 39 JSON_RESULTS_FILE_SMALL = "results-small.json"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 SKIP_STRING: SKIP, 104 SKIP_STRING: SKIP,
104 TEXT_STRING: TEXT, 105 TEXT_STRING: TEXT,
105 TIMEOUT_STRING: TIMEOUT, 106 TIMEOUT_STRING: TIMEOUT,
106 LEAK_STRING: LEAK, 107 LEAK_STRING: LEAK,
107 } 108 }
108 109
109 # FIXME: Use dict comprehensions once we update the server to python 2.7. 110 # FIXME: Use dict comprehensions once we update the server to python 2.7.
110 CHAR_TO_FAILURE = dict((value, key) for key, value in FAILURE_TO_CHAR.items()) 111 CHAR_TO_FAILURE = dict((value, key) for key, value in FAILURE_TO_CHAR.items())
111 112
112 def _is_directory(subtree): 113 def _is_directory(subtree):
113 return RESULTS_KEY not in subtree 114 return RESULTS_KEY not in subtree or not isinstance(subtree[RESULTS_KEY], co llections.Sequence)
114 115
115 116
116 class JsonResults(object): 117 class JsonResults(object):
117 @staticmethod 118 @staticmethod
118 def is_aggregate_file(name): 119 def is_aggregate_file(name):
119 return name in (JSON_RESULTS_FILE, JSON_RESULTS_FILE_SMALL) 120 return name in (JSON_RESULTS_FILE, JSON_RESULTS_FILE_SMALL)
120 121
121 @classmethod 122 @classmethod
122 def _strip_prefix_suffix(cls, data): 123 def _strip_prefix_suffix(cls, data):
123 if data.startswith(JSON_RESULTS_PREFIX) and data.endswith(JSON_RESULTS_S UFFIX): 124 if data.startswith(JSON_RESULTS_PREFIX) and data.endswith(JSON_RESULTS_S UFFIX):
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 524
524 check_json_error_string = cls._check_json(builder, json) 525 check_json_error_string = cls._check_json(builder, json)
525 if check_json_error_string: 526 if check_json_error_string:
526 return None 527 return None
527 528
528 test_list_json = {} 529 test_list_json = {}
529 tests = json[builder][TESTS_KEY] 530 tests = json[builder][TESTS_KEY]
530 cls._delete_results_and_times(tests) 531 cls._delete_results_and_times(tests)
531 test_list_json[builder] = {TESTS_KEY: tests} 532 test_list_json[builder] = {TESTS_KEY: tests}
532 return cls._generate_file_data(test_list_json) 533 return cls._generate_file_data(test_list_json)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698