Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 475503005: Handle tries of results data in upload (fix _is_directory). (Closed)

Created:
6 years, 4 months ago by Dirk Pranke
Modified:
6 years, 4 months ago
Reviewers:
ojan
CC:
blink-reviews, szager1
Project:
blink
Visibility:
Public.

Description

Handle tries of results data in upload (fix _is_directory) for TestResultsServer The file handler was getting confused when we would upload a full_results.json that contained a "results" key that pointed to a trie of tests. Also fix some file permissions issues that the presubmit check complained about. R=ojan@chromium.org BUG=403663 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180310

Patch Set 1 #

Patch Set 2 : restore +x #

Patch Set 3 : add a test, fix unrelated failing unittest #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M Tools/TestResultServer/handlers/buildershandler_unittest.py View 1 2 1 chunk +1 line, -1 line 1 comment Download
M Tools/TestResultServer/model/jsonresults.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M Tools/TestResultServer/model/jsonresults_unittest.py View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Dirk Pranke
6 years, 4 months ago (2014-08-14 22:39:15 UTC) #1
ojan
lgtm no test?
6 years, 4 months ago (2014-08-14 23:15:55 UTC) #2
Dirk Pranke
On 2014/08/14 23:15:55, ojan-only-code-yellow-reviews wrote: > lgtm > > no test? I will see if ...
6 years, 4 months ago (2014-08-14 23:18:42 UTC) #3
Dirk Pranke
Okay, I've added something close to a test, but I don't know if I have ...
6 years, 4 months ago (2014-08-14 23:43:31 UTC) #4
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 4 months ago (2014-08-15 00:26:19 UTC) #5
ojan
lgtm https://codereview.chromium.org/475503005/diff/40001/Tools/TestResultServer/handlers/buildershandler_unittest.py File Tools/TestResultServer/handlers/buildershandler_unittest.py (right): https://codereview.chromium.org/475503005/diff/40001/Tools/TestResultServer/handlers/buildershandler_unittest.py#newcode102 Tools/TestResultServer/handlers/buildershandler_unittest.py:102: 'groups': ['@ToT Chromium', '@ToT Blink'], Whoops. This was ...
6 years, 4 months ago (2014-08-15 00:26:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/475503005/40001
6 years, 4 months ago (2014-08-15 00:27:37 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (40001) as 180310
6 years, 4 months ago (2014-08-15 00:28:42 UTC) #8
Dirk Pranke
On 2014/08/15 00:26:20, ojan-only-code-yellow-reviews wrote: >I really need to add a script to run all ...
6 years, 4 months ago (2014-08-15 00:30:49 UTC) #9
ojan
6 years, 4 months ago (2014-08-15 00:49:02 UTC) #10
Message was sent while issue was closed.
On 2014/08/15 at 00:30:49, dpranke wrote:
> On 2014/08/15 00:26:20, ojan-only-code-yellow-reviews wrote:
> >I really need to add a script to run all the TestResultServer python tests.
> 
> test-webkitpy will run the tests if you have the GAE SDK installed. If we have
the SDK checked in somewhere (we do, I think), we could just add that to
sys.path instead and always run it.

That'd be awesome.

Powered by Google App Engine
This is Rietveld 408576698