Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py

Issue 475503004: Support None value for telemetry values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py
diff --git a/tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py b/tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py
index d4f77af1c1aa50427167bb73599df3cd965a29ee..04ce19c40f317bea208c484c641bdaea1915cac9 100644
--- a/tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py
+++ b/tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py
@@ -17,7 +17,6 @@ from telemetry.web_perf.metrics.rendering_stats import (
ComputeInputEventLatencies)
from telemetry.web_perf.metrics.rendering_stats import GetInputLatencyEvents
from telemetry.web_perf.metrics.rendering_stats import HasRenderingStats
-from telemetry.web_perf.metrics.rendering_stats import NotEnoughFramesError
from telemetry.web_perf.metrics.rendering_stats import RenderingStats
@@ -252,46 +251,6 @@ class RenderingStatsUnitTest(unittest.TestCase):
process_with_frames.FinalizeImport()
self.assertTrue(HasRenderingStats(thread_with_frames))
- def testRangeWithoutFrames(self):
- timer = MockTimer()
- timeline = model.TimelineModel()
-
- # Create a renderer process, with a main thread and impl thread.
- renderer = timeline.GetOrCreateProcess(pid = 2)
- renderer_main = renderer.GetOrCreateThread(tid = 21)
- renderer_compositor = renderer.GetOrCreateThread(tid = 22)
-
- # Create 10 main and impl rendering stats events for Action A.
- timer.Advance(2, 4)
- renderer_main.BeginSlice('webkit.console', 'ActionA', timer.Get(), '')
- for i in xrange(0, 10):
- first = (i == 0)
- AddMainThreadRenderingStats(timer, renderer_main, first, None)
- AddImplThreadRenderingStats(timer, renderer_compositor, first, None)
- timer.Advance(2, 4)
- renderer_main.EndSlice(timer.Get())
-
- # Create 5 main and impl rendering stats events not within any action.
- for i in xrange(0, 5):
- first = (i == 0)
- AddMainThreadRenderingStats(timer, renderer_main, first, None)
- AddImplThreadRenderingStats(timer, renderer_compositor, first, None)
-
- # Create Action B without any frames. This should trigger
- # NotEnoughFramesError when the RenderingStats object is created.
- timer.Advance(2, 4)
- renderer_main.BeginSlice('webkit.console', 'ActionB', timer.Get(), '')
- timer.Advance(2, 4)
- renderer_main.EndSlice(timer.Get())
-
- renderer.FinalizeImport()
-
- timeline_markers = timeline.FindTimelineMarkers(['ActionA', 'ActionB'])
- timeline_ranges = [ timeline_bounds.Bounds.CreateFromEvent(marker)
- for marker in timeline_markers ]
- self.assertRaises(NotEnoughFramesError, RenderingStats,
- renderer, None, timeline_ranges)
-
def testFromTimeline(self):
timeline = model.TimelineModel()

Powered by Google App Engine
This is Rietveld 408576698