Wire easy unlock settings UI

Wire easy unlock settings UI

- Add API to get/set/clear the pairing info into user prefs;
- Add an onTurnFlowFinished event so that the app can clear its state;
- Extend EasyUnlockService to store pairing info and provide
  turn-off flow support;
- Update settings UI to trigger turn off flow and observe
  the turn-off flow status to show pending/error or dismiss when done;
- Add EasyUnlockToggleFlow to wrap api calls to server;
- Update OAuth2ApiFlow to support application/json content-type and
  handle 204 as success;

BUG=397356, 394640
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290019

[xiyuan, 2014-08-13 23:26:47]

Suggested split:

tengs/tbarzic: Please drive the review and you guys can split as you want. :)

rogerta:
  google_apis/gaia/oauth2_api_call_flow.*

asargent:
  extensions/*

isherman:
  histograms.xml

All are welcome to review any parts of the CL. :) Thanks.

[Ilya Sherman, 2014-08-13 23:45:53]

histograms lgtm

[Tim Song, 2014-08-14 07:57:41]

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/signin/ea...
File chrome/browser/signin/easy_unlock_service.cc (right):

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.cc:268: ClearPermitAccess();
We shouldn't clear the permit access here. We are now enrolling to CryptAuth
before Easy Unlock is enabled, and we periodically re-enroll every few weeks.
The permit access (public key and private key) will be reused for
re-enrollments.

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/easy_unlock_handler.cc (right):

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/easy_unlock_handler.cc:63: void
EasyUnlockHandler::OnTurnOffOperationStatusChanged() {
Out of curiosity, what happens to the overlay when the turn of flow succeeds?
From reading this code, it looks like the overlay just goes back to the IDLE
state. Does this overlay get automatically dismissed somehow?

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/easy_unlock_handler.cc:87: status_string =
"idle";
Did you mean "unknown"?

https://codereview.chromium.org/475483003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://codereview.chromium.org/475483003/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/easy_unlock_private.idl:69: // The id of the permit
record.
This should say the ID of the permit, which identifies the service/application
that these permit records are used in.

https://codereview.chromium.org/475483003/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/easy_unlock_private.idl:79: // Base64 encoded
payload data of the record.
Websafe Base64

https://codereview.chromium.org/475483003/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/easy_unlock_private.idl:214: static void
onTurnOffFlowFinished();
We shouldn't need this event. If we clear the devices, the app should be in the
correct state upon reload. We can just reload the app upon the completion of the
turn off flow.

[tbarzic, 2014-08-14 17:43:24]

lgtm

https://codereview.chromium.org/475483003/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/easy_unlock_turn_off_overlay.js (right):

https://codereview.chromium.org/475483003/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/easy_unlock_turn_off_overlay.js:42: var
oldState = this.uiState_;
you don't use oldState

also, consider adding
if (newUiState == this.uiState_)
  return;

https://codereview.chromium.org/475483003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://codereview.chromium.org/475483003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/easy_unlock_private.idl:22: enum PermitType
{access, license};
other enums are in all caps

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/signin/ea...
File chrome/browser/signin/easy_unlock_service.cc (right):

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.cc:198: phone_public_key,
can you add a TODO for handling multiple phones (and a comment that currently
there ought to be at most one registered phone)

[Roger Tawa OOO till Jul 10th, 2014-08-14 17:50:46]

google_apis\gaia lgtm

[xiyuan, 2014-08-14 22:09:20]

https://codereview.chromium.org/475483003/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/easy_unlock_turn_off_overlay.js (right):

https://codereview.chromium.org/475483003/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/easy_unlock_turn_off_overlay.js:42: var
oldState = this.uiState_;
On 2014/08/14 17:43:23, tbarzic wrote:
> you don't use oldState
> 
> also, consider adding
> if (newUiState == this.uiState_)
>   return;

Done.

https://codereview.chromium.org/475483003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://codereview.chromium.org/475483003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/easy_unlock_private.idl:22: enum PermitType
{access, license};
On 2014/08/14 17:43:23, tbarzic wrote:
> other enums are in all caps

This has to match the enum defined in permit.PermitRecord.Type. Added a comment.

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/signin/ea...
File chrome/browser/signin/easy_unlock_service.cc (right):

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.cc:198: phone_public_key,
On 2014/08/14 17:43:24, tbarzic wrote:
> can you add a TODO for handling multiple phones (and a comment that currently
> there ought to be at most one registered phone)

Done.

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.cc:268: ClearPermitAccess();
On 2014/08/14 07:57:41, Tim Song wrote:
> We shouldn't clear the permit access here. We are now enrolling to CryptAuth
> before Easy Unlock is enabled, and we periodically re-enroll every few weeks.
> The permit access (public key and private key) will be reused for
> re-enrollments.

Done. And update the has_paring logic in browser_options_handler.cc

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/easy_unlock_handler.cc (right):

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/easy_unlock_handler.cc:63: void
EasyUnlockHandler::OnTurnOffOperationStatusChanged() {
On 2014/08/14 07:57:41, Tim Song wrote:
> Out of curiosity, what happens to the overlay when the turn of flow succeeds?
> From reading this code, it looks like the overlay just goes back to the IDLE
> state. Does this overlay get automatically dismissed somehow?

It will be dismissed when pairing data is cleared. See browser_options.js,
updateEasyUnlock_.

https://codereview.chromium.org/475483003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/easy_unlock_handler.cc:87: status_string =
"idle";
On 2014/08/14 07:57:41, Tim Song wrote:
> Did you mean "unknown"?

Done. And updated easy_unlock_turn_off_overlay.js to treat "unknown" to show
default UI.

https://codereview.chromium.org/475483003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://codereview.chromium.org/475483003/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/easy_unlock_private.idl:69: // The id of the permit
record.
On 2014/08/14 07:57:41, Tim Song wrote:
> This should say the ID of the permit, which identifies the service/application
> that these permit records are used in.

Done.

https://codereview.chromium.org/475483003/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/easy_unlock_private.idl:79: // Base64 encoded
payload data of the record.
On 2014/08/14 07:57:41, Tim Song wrote:
> Websafe Base64

Done.

https://codereview.chromium.org/475483003/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/easy_unlock_private.idl:214: static void
onTurnOffFlowFinished();
On 2014/08/14 07:57:41, Tim Song wrote:
> We shouldn't need this event. If we clear the devices, the app should be in
the
> correct state upon reload. We can just reload the app upon the completion of
the
> turn off flow. 

Done.

[Tim Song, 2014-08-14 23:14:56]

lgtm

[xiyuan, 2014-08-15 00:17:57]

yoz@, are you okay with stamping on extensions/ code since Antony seems to be
OOO? Thanks.

[Yoyo Zhou, 2014-08-15 01:38:59]

You can get an owners LGTM from me, but I don't know anything about this API.

[xiyuan, 2014-08-15 03:29:26]

On 2014/08/15 01:38:59, Yoyo Zhou wrote:
> You can get an owners LGTM from me, but I don't know anything about this API.

Understand. Appreciate the stamping. :)

[xiyuan, 2014-08-15 05:29:18]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-08-15 05:31:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xiyuan@chromium.org/475483003/120001

[commit-bot: I haz the power, 2014-08-15 07:30:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-15 15:56:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 15:56:26]

Failed to apply patch for
extensions/browser/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file extensions/browser/extension_function_histogram_value.h
  Hunk #1 FAILED at 935.
  1 out of 1 hunk FAILED -- saving rejects to file
extensions/browser/extension_function_histogram_value.h.rej

Patch:       extensions/browser/extension_function_histogram_value.h
Index: extensions/browser/extension_function_histogram_value.h
diff --git a/extensions/browser/extension_function_histogram_value.h
b/extensions/browser/extension_function_histogram_value.h
index
a46a7009b059b3eb92d52aeeaf6a0169fdc341d1..9a8687e4b1abd8c1dced096be62f56ff7d242907
100644
--- a/extensions/browser/extension_function_histogram_value.h
+++ b/extensions/browser/extension_function_histogram_value.h
@@ -935,6 +935,11 @@ enum HistogramValue {
   USBPRIVATE_GETDEVICES,
   USBPRIVATE_GETDEVICEINFO,
   EASYUNLOCKPRIVATE_UPDATESCREENLOCKSTATE,
+  EASYUNLOCKPRIVATE_SETPERMITACCESS,
+  EASYUNLOCKPRIVATE_GETPERMITACCESS,
+  EASYUNLOCKPRIVATE_CLEARPERMITACCESS,
+  EASYUNLOCKPRIVATE_SETREMOTEDEVICES,
+  EASYUNLOCKPRIVATE_GETREMOTEDEVICES,
   // Last entry: Add new entries above and ensure to update
   // tools/metrics/histograms/histograms/histograms.xml.
   ENUM_BOUNDARY

[xiyuan, 2014-08-15 16:16:20]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-08-15 16:17:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xiyuan@chromium.org/475483003/140001

[commit-bot: I haz the power, 2014-08-15 20:02:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-15 21:42:42]

Committed patchset #6 (140001) as 290019