Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 475483002: Revert "Make SingleThreadProxy a SchedulerClient" (Closed)

Created:
6 years, 4 months ago by enne (OOO)
Modified:
6 years, 4 months ago
CC:
android-webview-reviews_chromium.org, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dcheng, jam, jbauman+watch_chromium.org, jochen+watch_chromium.org, kalyank, matthewyuan, piman+watch_chromium.org, sievers+watch_chromium.org, tfarina, Ian Vollick
Project:
chromium
Visibility:
Public.

Description

Revert "Make SingleThreadProxy a SchedulerClient" This reverts commit r288866 because of crashes. Old patch: https://codereview.chromium.org/134623005/ NOTRY=true TBR=danakj@chromium.org,boliu@chromium.org,piman@chromium.org,ben@chromium.org BUG=402943, 403400 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -665 lines) Patch
M android_webview/browser/hardware_renderer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/scheduler/scheduler.h View 2 chunks +8 lines, -7 lines 0 comments Download
M cc/scheduler/scheduler.cc View 9 chunks +12 lines, -15 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.h View 4 chunks +6 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 5 chunks +46 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_perftest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_single_thread_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 10 chunks +31 lines, -62 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 9 chunks +38 lines, -18 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
D cc/trees/scoped_abort_remaining_swap_promises.h View 1 chunk +0 lines, -30 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 7 chunks +7 lines, -40 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 17 chunks +67 lines, -298 lines 0 comments Download
M cc/trees/thread_proxy.cc View 4 chunks +18 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/menu_view_drag_and_drop_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 3 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 6 chunks +27 lines, -9 lines 0 comments Download
M content/renderer/render_widget.h View 3 chunks +1 line, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 5 chunks +9 lines, -17 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/compositor/compositor.h View 5 chunks +24 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 8 chunks +100 lines, -24 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 8 chunks +15 lines, -25 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.h View 2 chunks +3 lines, -12 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.cc View 2 chunks +8 lines, -14 lines 0 comments Download
M ui/compositor/test/test_compositor_host_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_ozone.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/compositor/test/test_compositor_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_x11.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/view_unittest.cc View 14 chunks +20 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 4 months ago (2014-08-13 18:27:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/475483002/1
6 years, 4 months ago (2014-08-13 18:29:29 UTC) #2
enne (OOO)
The CQ bit was unchecked by enne@chromium.org
6 years, 4 months ago (2014-08-13 22:19:33 UTC) #3
enne (OOO)
This had some conflicts to revert, so I wanted to send it through the CQ. ...
6 years, 4 months ago (2014-08-13 22:20:24 UTC) #4
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 4 months ago (2014-08-13 22:20:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/475483002/1
6 years, 4 months ago (2014-08-13 22:23:41 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 22:36:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (1) as 289395

Powered by Google App Engine
This is Rietveld 408576698