Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 475463003: Fix pointer iteration for maps. (Closed)

Created:
6 years, 4 months ago by Jarin
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix pointer iteration for maps. BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23114

Patch Set 1 #

Patch Set 2 : Add regression test #

Total comments: 2

Patch Set 3 : Update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -3 lines) Patch
M src/heap/store-buffer.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jarin
This should avoid treating instance_size field in a map as a heap pointer (this was ...
6 years, 4 months ago (2014-08-13 19:26:15 UTC) #1
Hannes Payer (out of office)
Awesome, thanks for fixing. The patch looks good, but could you also add a regression ...
6 years, 4 months ago (2014-08-13 19:52:52 UTC) #2
Jarin
On 2014/08/13 19:52:52, Hannes Payer wrote: > Awesome, thanks for fixing. The patch looks good, ...
6 years, 4 months ago (2014-08-14 07:18:33 UTC) #3
Hannes Payer (out of office)
lgtm, with one comment nit https://codereview.chromium.org/475463003/diff/20001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/475463003/diff/20001/test/cctest/test-heap.cc#newcode4501 test/cctest/test-heap.cc:4501: // the map. Can ...
6 years, 4 months ago (2014-08-14 07:27:32 UTC) #4
Hannes Payer (out of office)
lgtm, with one comment nit https://codereview.chromium.org/475463003/diff/20001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/475463003/diff/20001/test/cctest/test-heap.cc#newcode4501 test/cctest/test-heap.cc:4501: // the map. Can ...
6 years, 4 months ago (2014-08-14 07:27:32 UTC) #5
Jarin
https://codereview.chromium.org/475463003/diff/20001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/475463003/diff/20001/test/cctest/test-heap.cc#newcode4501 test/cctest/test-heap.cc:4501: // the map. On 2014/08/14 07:27:32, Hannes Payer wrote: ...
6 years, 4 months ago (2014-08-14 07:37:33 UTC) #6
Jarin
6 years, 4 months ago (2014-08-14 07:41:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as 23114 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698