extensions/browser/api/cast_channel/cast_socket.cc - Issue 475463002: Cast channel logging: log additional statistics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_socket.cc

Issue 475463002: Cast channel logging: log additional statistics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@REAL-NEW-MASTER

Patch Set: Addressed comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/cast_channel/cast_socket.cc

diff --git a/extensions/browser/api/cast_channel/cast_socket.cc b/extensions/browser/api/cast_channel/cast_socket.cc

index e29d4921df526f6671939233482e17f15cdc92c2..32786721c93fb04dc62e4490b2f858ea855743f2 100644

--- a/extensions/browser/api/cast_channel/cast_socket.cc

+++ b/extensions/browser/api/cast_channel/cast_socket.cc

@@ -713,8 +713,9 @@ int CastSocket::DoWriteComplete(int result) {

int CastSocket::DoWriteCallback() {

DCHECK(!write_queue_.empty());

- write_state_ = WRITE_STATE_WRITE;

- logger_->LogSocketWriteState(channel_id_, WriteStateToProto(write_state_));

+ SetWriteState(WRITE_STATE_WRITE);

WriteRequest& request = write_queue_.front();

int bytes_consumed = request.io_buffer->BytesConsumed();

logger_->LogSocketEventForMessage(

« no previous file with comments | « no previous file | extensions/browser/api/cast_channel/logger.h » ('j') | extensions/browser/api/cast_channel/logger.cc » ('J')