Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: extensions/browser/api/cast_channel/logging.proto

Issue 475463002: Cast channel logging: log additional statistics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@REAL-NEW-MASTER
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/cast_channel/logging.proto
diff --git a/extensions/browser/api/cast_channel/logging.proto b/extensions/browser/api/cast_channel/logging.proto
index 57bd461ba1dffbb0196e4accd7539627b39a3d5a..bd1884e16690287751193cb2e8f3a852168a3146 100644
--- a/extensions/browser/api/cast_channel/logging.proto
+++ b/extensions/browser/api/cast_channel/logging.proto
@@ -131,6 +131,8 @@ message AggregatedSocketEvent {
optional int32 endpoint_id = 2;
optional ChannelAuth channel_auth_type = 3;
repeated SocketEvent socket_event = 4;
+ optional int64 bytes_read = 5;
+ optional int64 bytes_written = 6;
}
message Log {
@@ -143,5 +145,6 @@ message Log {
// Number of event log entries evicted by the logger due to size constraints.
optional int32 num_evicted_socket_events = 3;
- // TODO(imcheng): Add other stats, such as bytes read/written across sockets.
+ optional int64 total_bytes_read = 4;
mark a. foltz 2014/08/13 22:06:31 Is this data interesting? It will be aggregated a
imcheng 2014/08/14 00:24:34 Yes, this was the intention.
+ optional int64 total_bytes_written = 5;
}

Powered by Google App Engine
This is Rietveld 408576698