Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: extensions/browser/api/cast_channel/logger.h

Issue 475463002: Cast channel logging: log additional statistics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@REAL-NEW-MASTER
Patch Set: Fix merge Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/cast_channel/cast_socket.cc ('k') | extensions/browser/api/cast_channel/logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/cast_channel/logger.h
diff --git a/extensions/browser/api/cast_channel/logger.h b/extensions/browser/api/cast_channel/logger.h
index 4bbe5ce822928f04135ea95ac927c42c7102f42a..e7e22ac84a740ba9f573a42249c63603a6fb1be5 100644
--- a/extensions/browser/api/cast_channel/logger.h
+++ b/extensions/browser/api/cast_channel/logger.h
@@ -117,18 +117,17 @@ class Logger : public base::RefCounted<Logger> {
// Records |event| associated with |channel_id|.
// If the internal map is already logging maximum number of sockets and this
// is a new socket, the socket with the smallest channel id will be discarded.
- // Returns a pointer to the Event proto with |event_type| and
- // timestamp populated.
- void LogSocketEvent(int channel_id, const proto::SocketEvent& socket_event);
+ // Returns a reference to the AggregatedSocketEvent proto created/modified.
+ proto::AggregatedSocketEvent& LogSocketEvent(
+ int channel_id,
+ const proto::SocketEvent& socket_event);
scoped_ptr<base::TickClock> clock_;
AggregatedSocketEventLogMap aggregated_socket_events_;
base::TimeTicks unix_epoch_time_ticks_;
- // Number of socket / event entries evicted by the logger due to size
- // constraints.
- int num_evicted_aggregated_socket_events_;
- int num_evicted_socket_events_;
+ // Log proto holding global statistics.
+ proto::Log log_;
base::ThreadChecker thread_checker_;
« no previous file with comments | « extensions/browser/api/cast_channel/cast_socket.cc ('k') | extensions/browser/api/cast_channel/logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698