Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 475433004: Add scraper to find paths that fallback to software (Closed)

Created:
6 years, 4 months ago by krajcevski
Modified:
6 years, 4 months ago
Reviewers:
krajcevski, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add scraper to find paths that fallback to software Committed: https://skia.googlesource.com/skia/+/0f149e5a78842c920c0ce1e1ac45f54473c11f05

Patch Set 1 #

Total comments: 4

Patch Set 2 : Count clips better #

Patch Set 3 : Add percentage of SKPs that need sw paths to script #

Patch Set 4 : Count SKPs per canvas not per invocation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -0 lines) Patch
A tools/lua/paths.lua View 1 2 3 1 chunk +124 lines, -0 lines 0 comments Download
A tools/lua/paths_agg.lua View 1 2 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
krajcevski
6 years, 4 months ago (2014-08-14 23:11:28 UTC) #1
robertphillips
I think you should also count the total number of clips since you will be ...
6 years, 4 months ago (2014-08-15 12:34:18 UTC) #2
krajcevski
Output on most recent 10k set: Number of clips: 746936 Number of draws: 6375958 Number ...
6 years, 4 months ago (2014-08-15 15:13:52 UTC) #3
robertphillips
lgtm
6 years, 4 months ago (2014-08-15 15:24:42 UTC) #4
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-15 15:32:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/475433004/20001
6 years, 4 months ago (2014-08-15 15:33:41 UTC) #6
krajcevski
Results on the 1M dataset: Number of clips: 52970366 Number of draws: 392621437 Number of ...
6 years, 4 months ago (2014-08-15 15:46:30 UTC) #7
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-15 19:24:27 UTC) #8
krajcevski
The CQ bit was unchecked by krajcevski@google.com
6 years, 4 months ago (2014-08-15 19:24:29 UTC) #9
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-15 19:24:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/475433004/40001
6 years, 4 months ago (2014-08-15 19:25:36 UTC) #11
krajcevski
Turns out that each shard runs the script on a bunch of SKPs at once, ...
6 years, 4 months ago (2014-08-15 19:58:17 UTC) #12
krajcevski
The CQ bit was unchecked by krajcevski@google.com
6 years, 4 months ago (2014-08-15 20:15:08 UTC) #13
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-15 20:22:05 UTC) #14
krajcevski
Number of clips: 52970366 Number of draws: 392621437 Number of clipped paths: 2684400 Number of ...
6 years, 4 months ago (2014-08-15 20:22:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/475433004/60001
6 years, 4 months ago (2014-08-15 20:22:57 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 14:52:29 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (60001) as 0f149e5a78842c920c0ce1e1ac45f54473c11f05

Powered by Google App Engine
This is Rietveld 408576698