| OLD | NEW |
|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 | 2 |
| 3 <html ng-app="Loader" ng-controller="Loader.Controller"> | 3 <html ng-app="Loader" ng-controller="Loader.Controller"> |
| 4 | 4 |
| 5 <head> | 5 <head> |
| 6 <title ng-bind="windowTitle"></title> | 6 <title ng-bind="windowTitle"></title> |
| 7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js"
></script> | 7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js"
></script> |
| 8 <script src="loader.js"></script> | 8 <script src="loader.js"></script> |
| 9 <link rel="stylesheet" href="view.css"> | 9 <link rel="stylesheet" href="view.css"> |
| 10 </head> | 10 </head> |
| 11 | 11 |
| 12 <body> | 12 <body> |
| 13 <h2> |
| 14 Instructions, roadmap, etc. are at |
| 15 <a href="http://tinyurl.com/SkiaRebaselineServer"> |
| 16 http://tinyurl.com/SkiaRebaselineServer |
| 17 </a> |
| 18 </h2> |
| 19 |
| 13 <em> | 20 <em> |
| 14 {{loadingMessage}} | 21 {{loadingMessage}} |
| 15 </em> | 22 </em> |
| 16 | 23 |
| 17 <div ng-hide="!categories"><!-- everything: hide until data is loaded --> | 24 <div ng-hide="!categories"><!-- everything: hide until data is loaded --> |
| 18 | 25 |
| 19 <div class="warning-div" | 26 <div class="warning-div" |
| 20 ng-hide="!(header.isEditable && header.isExported)"> | 27 ng-hide="!(header.isEditable && header.isExported)"> |
| 21 WARNING! These results are editable and exported, so any user | 28 WARNING! These results are editable and exported, so any user |
| 22 who can connect to this server over the network can modify them. | 29 who can connect to this server over the network can modify them. |
| 23 </div> | 30 </div> |
| 24 | 31 |
| 25 <div class="todo-div"><!-- TODOs --> | |
| 26 <p> | |
| 27 TODO(epoger): | |
| 28 <input type="checkbox" ng-model="showTodos"> | |
| 29 show | |
| 30 <ul ng-hide="!showTodos"> | |
| 31 <li> | |
| 32 If server was run with --reload flag, automatically check for | |
| 33 new results and tell the user when new results are available | |
| 34 (the user can reload the page if he wants to see them). | |
| 35 </li><li> | |
| 36 Add pixel diffs, and sorting by percentage of different pixels | |
| 37 </li><li> | |
| 38 Add ability to sort/filter by reviewed-by-human. Depends on | |
| 39 <a href="https://code.google.com/p/skia/issues/detail?id=1758"> | |
| 40 bug 1758 | |
| 41 </a> | |
| 42 ('rebaseline_server: make the "categories" struct passed from server t
o client a list instead of a dict') | |
| 43 </li><li> | |
| 44 Improve the column sorting, as per | |
| 45 <a href="http://jsfiddle.net/vojtajina/js64b/14/"> | |
| 46 http://jsfiddle.net/vojtajina/js64b/14/ | |
| 47 </a> | |
| 48 </li><li> | |
| 49 For the text-filtered categories, allow regular expression matching | |
| 50 (or Unix-style wildcard matching) instead of simple substring match? | |
| 51 <!-- In order to do this efficiently, we should probably do the | |
| 52 expression matching over the list of categories returned, | |
| 53 use that to generate a list of category values that fulfill the | |
| 54 regex, and when filtering the results just look for category | |
| 55 values within that list. --> | |
| 56 </li><li> | |
| 57 Right now, if you change which column is used to | |
| 58 sort the data, the column widths may fluctuate based on the | |
| 59 longest string <i>currently visible</i> within the top {{displayLimit}
} | |
| 60 results. Can we fix the column widths to be wide enough to hold | |
| 61 any result, even the currently hidden results? | |
| 62 </li> | |
| 63 </ul> | |
| 64 </div><!-- TODOs --> | |
| 65 | |
| 66 <div ng-hide="!(header.timeUpdated)"> | 32 <div ng-hide="!(header.timeUpdated)"> |
| 67 Results current as of {{localTimeString(header.timeUpdated)}} | 33 Results current as of {{localTimeString(header.timeUpdated)}} |
| 68 </div> | 34 </div> |
| 69 | 35 |
| 70 <div><!-- tabs --> | 36 <div><!-- tabs --> |
| 71 <div class="tab-spacer" ng-repeat="tab in tabs"> | 37 <div class="tab-spacer" ng-repeat="tab in tabs"> |
| 72 <div class="tab-{{tab == viewingTab}}" | 38 <div class="tab-{{tab == viewingTab}}" |
| 73 ng-click="setViewingTab(tab)"> | 39 ng-click="setViewingTab(tab)"> |
| 74 {{tab}} ({{numResultsPerTab[tab]}}) | 40 {{tab}} ({{numResultsPerTab[tab]}}) |
| 75 </div> | 41 </div> |
| (...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 335 <!-- TODO(epoger): Can we get the base URLs (commondatastorage and | 301 <!-- TODO(epoger): Can we get the base URLs (commondatastorage and |
| 336 issues list) from | 302 issues list) from |
| 337 http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json | 303 http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json |
| 338 ? I tried importing the | 304 ? I tried importing the |
| 339 http://skia.googlecode.com/svn/buildbot/skia_tools.js script and using | 305 http://skia.googlecode.com/svn/buildbot/skia_tools.js script and using |
| 340 that to do so, but I got Access-Control-Allow-Origin errors. | 306 that to do so, but I got Access-Control-Allow-Origin errors. |
| 341 --> | 307 --> |
| 342 | 308 |
| 343 </body> | 309 </body> |
| 344 </html> | 310 </html> |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 47543008:
rebaseline_server: replace TODOs section with link to documentation/roadmap (Closed)
Base URL: http://skia.googlecode.com/svn/trunk/