Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 47543003: Mojo: Add basic IDL parser. (Closed)

Created:
7 years, 1 month ago by darin (slow to review)
Modified:
7 years, 1 month ago
Reviewers:
DaveMoore
CC:
chromium-reviews, Aaron Boodman, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Add basic IDL parser and frontend mojo_parser - parses IDL, produces syntax tree mojo_translate - translates syntax tree to Mojom IR mojo_idl - frontend that hooks it all together The result "mojo_idl foo.idl" ingests the IDL file and spits out C++ code! R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231860

Patch Set 1 #

Patch Set 2 : renaming #

Patch Set 3 : Now capable of parsing sample_service.idl #

Patch Set 4 : Now with mojo_translate.py, which generates Mojom IR #

Patch Set 5 : #

Patch Set 6 : rebase #

Patch Set 7 : Now with mojo_idl frontend #

Patch Set 8 : It's alive! #

Patch Set 9 : Style improvements #

Patch Set 10 : A bit more object oriented. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, --2 lines) Patch
A + mojo/public/bindings/generators/__init__.py View 1 2 3 4 5 6 7 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/public/bindings/mojo_idl.py View 1 2 3 4 5 6 7 8 1 chunk +36 lines, -0 lines 0 comments Download
A + mojo/public/bindings/parser/__init__.py View 1 2 3 4 5 6 7 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/public/bindings/parser/mojo_parser.py View 1 2 3 4 5 6 7 8 1 chunk +232 lines, -0 lines 0 comments Download
A mojo/public/bindings/parser/mojo_translate.py View 1 2 3 4 5 6 7 8 9 1 chunk +115 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
Ready for review.
7 years, 1 month ago (2013-10-30 16:48:33 UTC) #1
DaveMoore
LGTM, I think this is all fine. But it might simplify the mojom generation code ...
7 years, 1 month ago (2013-10-30 17:03:10 UTC) #2
darin (slow to review)
Agreed. There's clearly too many translation layers! I'll add a TODO. -Darin On Wed, Oct ...
7 years, 1 month ago (2013-10-30 17:04:45 UTC) #3
darin (slow to review)
7 years, 1 month ago (2013-10-30 17:12:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #10 manually as r231860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698