Implement Function.prototype.toMethod.

test/mjsunit/harmony/toMethod.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
 //     * Neither the name of Google Inc. nor the names of its
 //       contributors may be used to endorse or promote products derived
 //       from this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+//
+// Flags: --harmony-classes --allow-natives-syntax
 
-// Flags: --allow-natives-syntax
 
-// Test usage of static type information for loads that would otherwise
-// turn into polymorphic or generic loads.
-
-// Prepare a highly polymorphic load to be used by all tests.
-Object.prototype.load = function() { return this.property; };
-Object.prototype.load.call({ A:0, property:10 });
-Object.prototype.load.call({ A:0, B:0, property:11 });
-Object.prototype.load.call({ A:0, B:0, C:0, property:12 });
-Object.prototype.load.call({ A:0, B:0, C:0, D:0, property:13 });
-Object.prototype.load.call({ A:0, B:0, C:0, D:0, E:0, property:14 });
-Object.prototype.load.call({ A:0, B:0, C:0, D:0, E:0, F:0, property:15 });
-
-// Test for object literals.
-(function() {
+(function () {

[arv (Not doing code reviews), 2014/08/15 22:28:48]

Please name these. Makes it easier to know what you are testing

(function TestSomething() {
  ...
})();

[Dmitry Lomov (no reviews), 2014/08/15 22:56:57]

Done.

   function f(x) {
-    var object = { property:x };
-    return object.load();
+    var a = [0, 1, 2]
+    return a[x];
   }
 
-  assertSame(1, f(1));
-  assertSame(2, f(2));
-  %OptimizeFunctionOnNextCall(f);
-  assertSame(3, f(3));
-})();
+  function ClassD() { }
 
-// Test for inlined constructors.
-(function() {
-  function c(x) {
-    this.property = x;
-  }
+  assertEquals(1, f(1));
+  var g = f.toMethod(ClassD.prototype);
+  assertEquals(1, g(1));
+  assertEquals(undefined, f[%HomeObjectSymbol()]);
+  assertEquals(ClassD.prototype, g[%HomeObjectSymbol()]);
+}());
+
+
+(function () {
   function f(x) {
-    var object = new c(x);
-    return object.load();
+    return function g(y)  { x++; return x + y; };
   }
 
-  assertSame(1, f(1));
-  assertSame(2, f(2));
-  %OptimizeFunctionOnNextCall(f);
-  assertSame(3, f(3));
-})();
+  function Base() {}
+  function Derived() { }
+  Derived.prototype = Object.create(Base.prototype);
+
+  var q = f(0);
+  assertEquals(2, q(1));
+  assertEquals(3, q(1));
+  var g = q.toMethod(Derived.prototype);
+  assertFalse(g === q);
+  assertEquals(4, g(1));
+  assertEquals(5, q(1));
+}());
+

[arv (Not doing code reviews), 2014/08/15 22:28:48]

two new lines between top level functions

[Dmitry Lomov (no reviews), 2014/08/15 22:56:57]

Done.

+(function() {
+  var sFun = Function.prototype.toMethod;
+  assertThrows(function() { sFun.call({}); }, TypeError);
+  function f(){};
+  assertThrows(function() { f.toMethod(1); }, TypeError);
+}());
+
+(function() {
+  var o = {};
+  var o1 = {};
+  function f() { }
+
+  function g() { }
+
+  var fMeth = f.toMethod(o);
+  assertEquals(o, fMeth[%HomeObjectSymbol()]);

[arv (Not doing code reviews), 2014/08/15 22:28:48]

Maybe define the private symbol in harmony-classes.js. That way there is no need
for the runtime function.

[Dmitry Lomov (no reviews), 2014/08/15 22:56:57]

I am not sure what the suggestion is.
a) we need HomeObjectSymbol outside of harmony-classes.js for codegen
b) without runtime function, how would we test this here?

[arv (Not doing code reviews), 2014/08/15 23:02:40]

The way we have done this before is that we define the symbol in the js file and
then we use INSTALL_NATIVE in bootstrapper

See symbolIterator for example.

+  g.__proto__ = fMeth;
+  assertEquals(undefined, g[%HomeObjectSymbol()]);
+  var gMeth = g.toMethod(o1);
+  assertEquals(fMeth, gMeth.__proto__);
+  assertEquals(o1, gMeth[%HomeObjectSymbol()]);
+}());
+
+(function() {
+  var o = {};
+  var p = {};
+
+
+  function f(x, y, z) {
+    assertEquals(o, this);
+    assertEquals(1, x);
+    assertEquals(2, y);
+    assertEquals(3, z);
+  }
+
+  var fBound = f.bind(o, 1, 2, 3);
+  var fMeth = fBound.toMethod(p);
+  fMeth();
+  fMeth.call(p);
+}());

[arv (Not doing code reviews), 2014/08/15 22:28:48]

Can you add a test that we check the type of the newHome in toMethod before we
test the type of this.

[Dmitry Lomov (no reviews), 2014/08/15 22:56:57]

I believe this is a spec bug.
Anyway, frankly not sure what is the good way to test the order of checks -
ideas?