Reland: Factor Chrome details out of update manifest fetching.

Reland: Factor Chrome details out of update manifest fetching.

Relanding of https://codereview.chromium.org/465543004
with a fix for official builds.

This establishes a ManifestFetchDataDelegate for use
by ExtensionDownloader and ManifestFetchData, and moves
ManifestFetchData into //extensions/browser/updater.

The delegate provides implementation details for
update manifest fetching, including brand code,
boilerplate query parameters, and ping data.

Chrome's implementation has knowledge of the
Google brand, the metrics service, and Omaha-specific
query parameters necessary for CRX item queries.

BUG=398671
TBR=isherman@chromium.org

Committed: https://crrev.com/db519299d767b02329fc7d9a1edb9af4527ef463
Cr-Commit-Position: refs/heads/master@{#295142}

[Ken Rockot(use gerrit already), 2014-08-15 14:43:31]

Ben, could I get a stamp for this re-landing patch? It was missing a header (for
google_brand in ChromeExtensionDownloaderFactory) and broke official builds :<

[not at google - send to devlin, 2014-08-15 15:15:43]

lgtm

[Ken Rockot(use gerrit already), 2014-08-15 15:16:01]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-08-15 15:17:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rockot@chromium.org/475423002/1

[commit-bot: I haz the power, 2014-08-15 18:07:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-15 19:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 19:38:00]

Failed to apply patch for chrome/browser/extensions/extension_system_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_system_impl.cc
  Hunk #1 FAILED at 29.
  Hunk #2 succeeded at 59 (offset 2 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/extensions/extension_system_impl.cc.rej

Patch:       chrome/browser/extensions/extension_system_impl.cc
Index: chrome/browser/extensions/extension_system_impl.cc
diff --git a/chrome/browser/extensions/extension_system_impl.cc
b/chrome/browser/extensions/extension_system_impl.cc
index
bb4617abb3362fb6995a1e62b6e1169ed8d75556..9a2a0fd8d969801019771e7db104dc0d0e1173f8
100644
--- a/chrome/browser/extensions/extension_system_impl.cc
+++ b/chrome/browser/extensions/extension_system_impl.cc
@@ -29,7 +29,6 @@
 #include "chrome/browser/extensions/standard_management_policy_provider.h"
 #include "chrome/browser/extensions/state_store_notification_observer.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
-#include "chrome/browser/extensions/updater/manifest_fetch_data.h"
 #include "chrome/browser/extensions/user_script_master.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
@@ -57,6 +56,7 @@
 #include "extensions/browser/quota_service.h"
 #include "extensions/browser/runtime_data.h"
 #include "extensions/browser/state_store.h"
+#include "extensions/browser/updater/manifest_fetch_data.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest.h"

[Ken Rockot(use gerrit already), 2014-08-15 19:48:09]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-08-15 19:50:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rockot@chromium.org/475423002/20001

[commit-bot: I haz the power, 2014-08-15 21:27:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/42481)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/47678)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-15 21:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 21:35:51]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2014-08-15 22:28:22]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-08-15 22:30:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rockot@chromium.org/475423002/40001

[commit-bot: I haz the power, 2014-08-16 05:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-16 05:50:08]

Failed to apply patch for chrome/browser/extensions/extension_service.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_service.cc
  Hunk #4 FAILED at 111.
  Hunk #5 succeeded at 317 (offset -2 lines).
  Hunk #6 FAILED at 581.
  2 out of 6 hunks FAILED -- saving rejects to file
chrome/browser/extensions/extension_service.cc.rej

Patch:       chrome/browser/extensions/extension_service.cc
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc
b/chrome/browser/extensions/extension_service.cc
index
6a2d1455d6b2efae53d9b48b39cc1110f91e0168..454ae8d2af33ba679039032d5dd5f44077997e57
100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -37,17 +37,15 @@
 #include "chrome/browser/extensions/permissions_updater.h"
 #include "chrome/browser/extensions/shared_module_service.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
+#include
"chrome/browser/extensions/updater/chrome_extension_downloader_factory.h"
 #include "chrome/browser/extensions/updater/extension_cache.h"
 #include "chrome/browser/extensions/updater/extension_downloader.h"
 #include "chrome/browser/extensions/updater/extension_updater.h"
+#include "chrome/browser/google/google_brand.h"
 #include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/signin/profile_identity_provider.h"
-#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
-#include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
 #include "chrome/browser/ui/webui/favicon_source.h"
 #include "chrome/browser/ui/webui/ntp/thumbnail_source.h"
-#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
 #include "chrome/browser/ui/webui/theme_source.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/crash_keys.h"
@@ -56,7 +54,6 @@
 #include "chrome/common/extensions/manifest_url_handler.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
-#include "components/signin/core/browser/signin_manager.h"
 #include "components/startup_metric_utils/startup_metric_utils.h"
 #include "content/public/browser/devtools_agent_host.h"
 #include "content/public/browser/notification_service.h"
@@ -92,8 +89,6 @@ using content::BrowserThread;
 using content::DevToolsAgentHost;
 using extensions::CrxInstaller;
 using extensions::Extension;
-using extensions::ExtensionDownloader;
-using extensions::ExtensionDownloaderDelegate;
 using extensions::ExtensionIdSet;
 using extensions::ExtensionInfo;
 using extensions::ExtensionRegistry;
@@ -116,15 +111,6 @@ namespace {
 // Wait this many seconds after an extensions becomes idle before updating it.
 const int kUpdateIdleDelay = 5;
 
-#if defined(ENABLE_EXTENSIONS)
-scoped_ptr<IdentityProvider> CreateWebstoreIdentityProvider(Profile* profile) {
-  return make_scoped_ptr<IdentityProvider>(new ProfileIdentityProvider(
-      SigninManagerFactory::GetForProfile(profile),
-      ProfileOAuth2TokenServiceFactory::GetForProfile(profile),
-      LoginUIServiceFactory::GetForProfile(profile)));
-}
-#endif  // defined(ENABLE_EXTENSIONS)
-
 }  // namespace
 
 // ExtensionService.
@@ -324,8 +310,8 @@ ExtensionService::ExtensionService(Profile* profile,
         profile,
         update_frequency,
         extensions::ExtensionCache::GetInstance(),
-        base::Bind(&ExtensionService::CreateExtensionDownloader,
-                   base::Unretained(this))));
+        base::Bind(ChromeExtensionDownloaderFactory::CreateForProfile,
+                   profile)));
   }
 
   component_loader_.reset(
@@ -586,20 +572,6 @@ bool ExtensionService::UpdateExtension(const std::string&
id,
   return true;
 }
 
-scoped_ptr<ExtensionDownloader> ExtensionService::CreateExtensionDownloader(
-    ExtensionDownloaderDelegate* delegate) {
-  scoped_ptr<ExtensionDownloader> downloader;
-#if defined(ENABLE_EXTENSIONS)
-  scoped_ptr<IdentityProvider> identity_provider =
-      CreateWebstoreIdentityProvider(profile_);
-  downloader.reset(new ExtensionDownloader(
-      delegate,
-      profile_->GetRequestContext()));
-  downloader->SetWebstoreIdentityProvider(identity_provider.Pass());
-#endif
-  return downloader.Pass();
-}
-
 void ExtensionService::ReloadExtensionImpl(
     // "transient" because the process of reloading may cause the reference
     // to become invalid. Instead, use |extension_id|, a copy.

[Ken Rockot(use gerrit already), 2014-09-16 17:42:44]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-09-16 17:43:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/475423002/60001

[commit-bot: I haz the power, 2014-09-16 18:02:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 18:02:56]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2014-09-16 18:06:24]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-09-16 18:07:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/475423002/80001

[commit-bot: I haz the power, 2014-09-16 19:45:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 19:45:40]

Failed to apply patch for
chrome/browser/metrics/chrome_metrics_service_accessor.h:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/metrics/chrome_metrics_service_accessor.h:12
  error: chrome/browser/metrics/chrome_metrics_service_accessor.h: patch does
not apply

Patch:       chrome/browser/metrics/chrome_metrics_service_accessor.h
Index: chrome/browser/metrics/chrome_metrics_service_accessor.h
diff --git a/chrome/browser/metrics/chrome_metrics_service_accessor.h
b/chrome/browser/metrics/chrome_metrics_service_accessor.h
index
edb5d2a205648484fcebf90e7d156bdb7d7112e4..e11f295ab9d1ed460c7bdf2ebead517788397f75
100644
--- a/chrome/browser/metrics/chrome_metrics_service_accessor.h
+++ b/chrome/browser/metrics/chrome_metrics_service_accessor.h
@@ -12,6 +12,7 @@
 #include "base/macros.h"
 #include "chrome/browser/metrics/metrics_service_accessor.h"
 
+class ChromeExtensionDownloaderFactory;
 class PrefService;
 class Profile;
 
@@ -27,8 +28,6 @@ void RegisterSwReporterComponent(ComponentUpdateService* cus,
 }
 
 namespace extensions {
-class ExtensionDownloader;
-class ManifestFetchData;
 class MetricsPrivateGetIsCrashReportingEnabledFunction;
 }
 
@@ -49,11 +48,10 @@ class ChromeMetricsServiceAccessor : public
MetricsServiceAccessor {
       component_updater::ComponentUpdateService* cus,
       PrefService* prefs);
   friend bool prerender::IsOmniboxEnabled(Profile* profile);
+  friend class ChromeExtensionDownloaderFactory;
   friend class ChromeRenderMessageFilter;
   friend class ::CrashesDOMHandler;
   friend class DataReductionProxyChromeSettings;
-  friend class extensions::ExtensionDownloader;
-  friend class extensions::ManifestFetchData;
   friend class extensions::MetricsPrivateGetIsCrashReportingEnabledFunction;
   friend class ::FlashDOMHandler;
   friend class system_logs::ChromeInternalLogSource;

[Ken Rockot(use gerrit already), 2014-09-16 19:51:30]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-09-16 19:52:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/475423002/100001

[commit-bot: I haz the power, 2014-09-16 21:27:16]

Committed patchset #6 (id:100001) as f7b11201f9457ed767896afc923f8cbd4ac5ba83

[commit-bot: I haz the power, 2014-09-16 21:27:53]

Patchset 6 (id:??) landed as
https://crrev.com/db519299d767b02329fc7d9a1edb9af4527ef463
Cr-Commit-Position: refs/heads/master@{#295142}