Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 475393002: DevTools: [CodeMirror] roll codemirror to v4.4.1 (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [CodeMirror] roll codemirror to v4.4.1 This rolls codemirror to 2b30a049fd, which is slightly later than 4.4.1. Layout test change: In codemirror version 4.4.1 the viewport update logic has changed and it no longer works if text editor offsetHeight is 0px. So creation of editor instance for tests now setups default editor height of 100px. R=apavlov BUG=404120 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180419

Patch Set 1 #

Patch Set 2 : fix creation of editor instance for test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -188 lines) Patch
M LayoutTests/inspector/editor/editor-test.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/cm/codemirror.js View 51 chunks +373 lines, -186 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
lushnikov
ptal
6 years, 4 months ago (2014-08-15 13:42:40 UTC) #1
apavlov
lgtm
6 years, 4 months ago (2014-08-15 13:45:22 UTC) #2
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 4 months ago (2014-08-15 13:45:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/475393002/1
6 years, 4 months ago (2014-08-15 13:45:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-15 15:08:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 15:36:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/20852)
6 years, 4 months ago (2014-08-15 15:36:24 UTC) #7
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-17 11:06:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/475393002/20001
6 years, 4 months ago (2014-08-17 11:06:52 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-17 12:04:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180419

Powered by Google App Engine
This is Rietveld 408576698