Don't clear the activeTab permission for same-origin navigations when the

Don't clear the activeTab permission for same-origin navigations when the
--scripts-require-action flag is on. The flag requirement is because we haven't
confirmed this is safe, but we need something like it for testing the flag.

BUG=404243
R=rdevlin.cronin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290080

[Devlin, 2014-08-15 21:24:01]

lgtm.  Might be good to chuck in an active tab test too at some point, but since
we're only using it for this feature right now, not a huge deal.

https://codereview.chromium.org/475333006/diff/1/chrome/browser/extensions/ac...
File chrome/browser/extensions/active_script_controller_unittest.cc (right):

https://codereview.chromium.org/475333006/diff/1/chrome/browser/extensions/ac...
chrome/browser/extensions/active_script_controller_unittest.cc:283: // Also test
that granting active tab runs any pending tasks.
this comment was somewhat misplaced before, and is now definitely misplaced.

https://codereview.chromium.org/475333006/diff/1/chrome/browser/extensions/ac...
File chrome/browser/extensions/active_tab_permission_granter.cc (right):

https://codereview.chromium.org/475333006/diff/1/chrome/browser/extensions/ac...
chrome/browser/extensions/active_tab_permission_granter.cc:99: if
(details.previous_url.GetOrigin() != details.entry->GetURL().GetOrigin() ||
I seem to recall that NavigationEntries are one of those pesky things that's
sometimes NULL.  Do we need to check that here?

[not at google - send to devlin, 2014-08-15 21:38:29]

Missed a test.

https://codereview.chromium.org/475333006/diff/1/chrome/browser/extensions/ac...
File chrome/browser/extensions/active_script_controller_unittest.cc (right):

https://codereview.chromium.org/475333006/diff/1/chrome/browser/extensions/ac...
chrome/browser/extensions/active_script_controller_unittest.cc:283: // Also test
that granting active tab runs any pending tasks.
On 2014/08/15 21:24:00, Devlin wrote:
> this comment was somewhat misplaced before, and is now definitely misplaced.

Done.

https://codereview.chromium.org/475333006/diff/1/chrome/browser/extensions/ac...
File chrome/browser/extensions/active_tab_permission_granter.cc (right):

https://codereview.chromium.org/475333006/diff/1/chrome/browser/extensions/ac...
chrome/browser/extensions/active_tab_permission_granter.cc:99: if
(details.previous_url.GetOrigin() != details.entry->GetURL().GetOrigin() ||
On 2014/08/15 21:24:00, Devlin wrote:
> I seem to recall that NavigationEntries are one of those pesky things that's
> sometimes NULL.  Do we need to check that here?

Ah yes, good point. Fixed.

[not at google - send to devlin, 2014-08-15 21:38:32]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-08-15 21:43:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/475333006/40001

[commit-bot: I haz the power, 2014-08-16 01:22:28]

Committed patchset #2 (40001) as 290080