[ServiceWorker] Sends the blob uuid of the request body to the ServiceWorker.

content/browser/service_worker/service_worker_controllee_request_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_controllee_request_handler.h"
 
 #include "content/browser/service_worker/service_worker_context_core.h"
 #include "content/browser/service_worker/service_worker_metrics.h"
 #include "content/browser/service_worker/service_worker_provider_host.h"
 #include "content/browser/service_worker/service_worker_registration.h"
 #include "content/browser/service_worker/service_worker_url_request_job.h"
 #include "content/browser/service_worker/service_worker_utils.h"
+#include "content/common/resource_request_body.h"
 #include "content/common/service_worker/service_worker_types.h"
 #include "net/base/load_flags.h"
 #include "net/base/net_util.h"
 #include "net/url_request/url_request.h"
 
 namespace content {
 
 ServiceWorkerControlleeRequestHandler::ServiceWorkerControlleeRequestHandler(
     base::WeakPtr<ServiceWorkerContextCore> context,
     base::WeakPtr<ServiceWorkerProviderHost> provider_host,
     base::WeakPtr<webkit_blob::BlobStorageContext> blob_storage_context,
-    ResourceType resource_type)
+    ResourceType resource_type,
+    scoped_refptr<ResourceRequestBody> body)
     : ServiceWorkerRequestHandler(context,
                                   provider_host,
                                   blob_storage_context,
                                   resource_type),
       is_main_resource_load_(
           ServiceWorkerUtils::IsMainResourceType(resource_type)),
+      body_(body),

[michaeln1, 2014/08/19 22:03:25]

It's pretty hidden that the body has a collection of
webkit_blob::BlobDataHandles attached to it using the userdata mechanism. Those
handles ensure the blobs don't get freed up for as long as the
ResourceRequestBody instance is around. ResolveBlobReference in the
UploadDataStreamBuilder sets that up.

It might be worth a comment. Also might be worth hoisting the SetUserData calls
up from the UploadDataStreamBuilder to somewhere closer to IPC message
deserialization (maybe RDH::BeginRequest) since there are two consumers
depending on that behavior now.

[horo, 2014/08/20 02:28:02]

Added comments in service_worker_url_request_job.h.
I will create another cl to move SetUserData calls.

       weak_factory_(this) {
 }
 
 ServiceWorkerControlleeRequestHandler::
     ~ServiceWorkerControlleeRequestHandler() {
   // Navigation triggers an update to occur shortly after the page and
   // its initial subresources load.
   if (provider_host_ && provider_host_->active_version()) {
     if (is_main_resource_load_)
       provider_host_->active_version()->ScheduleUpdate();
@@ skipping 31 matching lines @@
   // tells we should fallback to network. (Case B-c)
   if (job_.get() && job_->ShouldFallbackToNetwork()) {
     job_ = NULL;
     return NULL;
   }
 
   // It's for original request (A) or redirect case (B-a or B-b).
   DCHECK(!job_.get() || job_->ShouldForwardToServiceWorker());
 
   job_ = new ServiceWorkerURLRequestJob(
-      request, network_delegate, provider_host_, blob_storage_context_);
+      request, network_delegate, provider_host_, blob_storage_context_, body_);
   if (is_main_resource_load_)
     PrepareForMainResource(request->url());
   else
     PrepareForSubResource();
 
   if (job_->ShouldFallbackToNetwork()) {
     // If we know we can fallback to network at this point (in case
     // the storage lookup returned immediately), just return NULL here to
     // fallback to network.
     job_ = NULL;
@@ skipping 89 matching lines @@
 }
 
 void ServiceWorkerControlleeRequestHandler::PrepareForSubResource() {
   DCHECK(job_.get());
   DCHECK(context_);
   DCHECK(provider_host_->active_version());
   job_->ForwardToServiceWorker();
 }
 
 }  // namespace content