Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 475263002: Stop all PeerConnections upon suspend from Blink side (Closed)

Created:
6 years, 4 months ago by vrk (LEFT CHROMIUM)
Modified:
6 years, 4 months ago
Reviewers:
jiayl
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Stop all PeerConnections upon suspend from Blink side BUG=403618 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291213

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/renderer/media/peer_connection_tracker.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.h View 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
vrk (LEFT CHROMIUM)
6 years, 4 months ago (2014-08-15 00:19:08 UTC) #1
jiayl
lgtm
6 years, 4 months ago (2014-08-15 16:14:40 UTC) #2
vrk (LEFT CHROMIUM)
The CQ bit was checked by vrk@chromium.org
6 years, 4 months ago (2014-08-20 20:58:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/475263002/20001
6 years, 4 months ago (2014-08-20 21:00:25 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 21:14:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 21:16:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/44378) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/7499) ios_rel_device ...
6 years, 4 months ago (2014-08-20 21:16:23 UTC) #7
vrk (LEFT CHROMIUM)
The CQ bit was checked by vrk@chromium.org
6 years, 4 months ago (2014-08-21 19:44:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/475263002/40001
6 years, 4 months ago (2014-08-21 19:45:15 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (40001) as 291213
6 years, 4 months ago (2014-08-21 22:11:28 UTC) #10
scottmg
A revert of this CL (patchset #3) has been created in https://codereview.chromium.org/493853004/ by scottmg@chromium.org. The ...
6 years, 4 months ago (2014-08-25 22:46:57 UTC) #11
scottmg
6 years, 4 months ago (2014-08-25 22:57:33 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3) has been created in
https://codereview.chromium.org/482443003/ by scottmg@chromium.org.

The reason for reverting is: Causing browser crashes due to race, BUG=404767..

Powered by Google App Engine
This is Rietveld 408576698