Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Issue 475233005: Setup heap-unittests and runtime-unittests. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Setup heap-unittests and runtime-unittests. Initial import of empty unit test suites for Toon and Hannes. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23190

Patch Set 1 #

Patch Set 2 : Also add heap-unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -91 lines) Patch
M build/all.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + test/heap-unittests/DEPS View 1 1 chunk +2 lines, -2 lines 0 comments Download
A test/heap-unittests/heap-unittest.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
A test/heap-unittests/heap-unittests.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
A test/heap-unittests/heap-unittests.cc View 1 1 chunk +46 lines, -0 lines 0 comments Download
A + test/heap-unittests/heap-unittests.gyp View 1 2 chunks +4 lines, -31 lines 0 comments Download
A + test/heap-unittests/heap-unittests.status View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/heap-unittests/testcfg.py View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + test/runtime-unittests/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
A test/runtime-unittests/runtime-unittests.h View 1 chunk +42 lines, -0 lines 0 comments Download
A + test/runtime-unittests/runtime-unittests.cc View 4 chunks +16 lines, -18 lines 0 comments Download
A + test/runtime-unittests/runtime-unittests.gyp View 1 2 chunks +4 lines, -31 lines 0 comments Download
A + test/runtime-unittests/runtime-unittests.status View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/runtime-unittests/testcfg.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/run-tests.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
FYI
6 years, 4 months ago (2014-08-19 10:33:32 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 4 months ago (2014-08-19 10:52:21 UTC) #2
Benedikt Meurer
6 years, 4 months ago (2014-08-19 10:55:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23190 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698