Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 475233003: DevTools: front-end part of color picker (behind experiment). (Closed)

Created:
6 years, 4 months ago by pfeldman
Modified:
6 years, 4 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: front-end part of color picker (behind experiment). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180378

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -5 lines) Patch
M Source/devtools/front_end/common/Settings.js View 2 chunks +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/common/utilities.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/Spectrum.js View 3 chunks +21 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/ResourceTreeModel.js View 2 chunks +10 lines, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 2 chunks +18 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
pfeldman
6 years, 4 months ago (2014-08-15 16:32:24 UTC) #1
vsevik
https://chromiumcodereview.appspot.com/475233003/diff/20001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://chromiumcodereview.appspot.com/475233003/diff/20001/Source/devtools/protocol.json#newcode691 Source/devtools/protocol.json:691: "handlers": ["browser"] Is this needed?
6 years, 4 months ago (2014-08-15 16:36:00 UTC) #2
vsevik
lgtm
6 years, 4 months ago (2014-08-15 16:36:06 UTC) #3
pfeldman
https://chromiumcodereview.appspot.com/475233003/diff/20001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://chromiumcodereview.appspot.com/475233003/diff/20001/Source/devtools/protocol.json#newcode691 Source/devtools/protocol.json:691: "handlers": ["browser"] Yep. It is issued from the browser.
6 years, 4 months ago (2014-08-15 16:37:56 UTC) #4
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-15 16:37:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/475233003/20001
6 years, 4 months ago (2014-08-15 16:38:22 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 17:38:03 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 180378

Powered by Google App Engine
This is Rietveld 408576698